Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(129)

Issue 2920523002: PPC/s390: [compiler] Ask compilation info, not isolate, about source positions flag. (Closed)

Created:
3 years, 6 months ago by JaideepBajwa
Modified:
3 years, 6 months ago
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/heads/master
Project:
v8
Visibility:
Public.

Description

PPC/s390: [compiler] Ask compilation info, not isolate, about source positions flag. Port 510ebfc3938883435220879ccaeea5109ecf7552 Port 8f61fbc671018e36f56637e9da3ac494dbb9afbc R=neis@chromium.org, joransiu@ca.ibm.com, jyan@ca.ibm.com, michael_dawson@ca.ibm.com BUG= LOG=N Review-Url: https://codereview.chromium.org/2920523002 Cr-Commit-Position: refs/heads/master@{#45648} Committed: https://chromium.googlesource.com/v8/v8/+/33ba31275e5a62a09f25a2905ec48e23ffb5a274

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -4 lines) Patch
M src/compiler/ppc/code-generator-ppc.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M src/compiler/s390/code-generator-s390.cc View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 15 (7 generated)
JaideepBajwa
ptal
3 years, 6 months ago (2017-05-31 18:23:24 UTC) #1
john.yan
lgtm
3 years, 6 months ago (2017-05-31 18:24:41 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2920523002/1
3 years, 6 months ago (2017-05-31 18:24:59 UTC) #4
commit-bot: I haz the power
Try jobs failed on following builders: v8_linux64_avx2_rel_ng on master.tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_avx2_rel_ng/builds/22706) v8_linux64_avx2_rel_ng_triggered on master.tryserver.v8 (JOB_FAILED, ...
3 years, 6 months ago (2017-05-31 18:36:27 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2920523002/1
3 years, 6 months ago (2017-05-31 19:11:31 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: v8_node_linux64_rel on master.tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_node_linux64_rel/builds/2816)
3 years, 6 months ago (2017-05-31 19:24:57 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2920523002/1
3 years, 6 months ago (2017-05-31 20:04:40 UTC) #12
commit-bot: I haz the power
3 years, 6 months ago (2017-05-31 20:18:45 UTC) #15
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/v8/v8/+/33ba31275e5a62a09f25a2905ec48e23ffb...

Powered by Google App Engine
This is Rietveld 408576698