Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(195)

Issue 2920503002: [Cronet] Fix test issue on Marshmallow, need to call parent setUp() (Closed)

Created:
3 years, 6 months ago by pauljensen
Modified:
3 years, 6 months ago
Reviewers:
mgersh
CC:
chromium-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

[Cronet] Fix test issue on Marshmallow, need to call parent setUp() setUp() needs to call super.setUp() to avoid null deref in super.tearDown(). CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_cronet_tester Review-Url: https://codereview.chromium.org/2920503002 Cr-Commit-Position: refs/heads/master@{#475988} Committed: https://chromium.googlesource.com/chromium/src/+/8c2fd4ff2c753e99594d8b239a45507ced394f82

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M components/cronet/android/test/javatests/src/org/chromium/net/CronetTestBaseTest.java View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 13 (7 generated)
pauljensen
Miriam, PTAL, thank you!
3 years, 6 months ago (2017-05-31 17:38:14 UTC) #3
mgersh
lgtm
3 years, 6 months ago (2017-05-31 17:40:39 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2920503002/1
3 years, 6 months ago (2017-05-31 17:43:01 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: cast_shell_linux on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linux/builds/379770) chromeos_amd64-generic_chromium_compile_only_ng on master.tryserver.chromium.linux (JOB_FAILED, ...
3 years, 6 months ago (2017-05-31 18:45:18 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2920503002/1
3 years, 6 months ago (2017-05-31 18:50:16 UTC) #10
commit-bot: I haz the power
3 years, 6 months ago (2017-05-31 19:54:09 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/8c2fd4ff2c753e99594d8b239a45...

Powered by Google App Engine
This is Rietveld 408576698