Fix chrome not launching through quick_launch

Fix chrome not launching through quick_launch

Previously, chrome only handled launching with launch mode MAKE_NEW.
Now it can also be launched with launch mode REUSE (which is the mode
quick_launch uses by default) and launch mode DEFAULT (which is
interpreted as REUSE).

Typing chrome into quick_launch restores focus only to the original 
chrome window; it doesn't restore focus to chrome windows launched
through quick_launch for some reason.

BUG=727837
Review-Url: https://codereview.chromium.org/2920473003
Cr-Commit-Position: refs/heads/master@{#476482}
Committed: https://chromium.googlesource.com/chromium/src/+/8ea647a2d24bd0cff32ac9c57cd4edba69eff66e

[alexanderdai, 2017-05-31 21:58:15]

Description was changed from

==========
Fix chrome not launching through quick_launch

Previously, chrome only handled launching with launch mode MAKE_NEW.
Now it can also be launched with launch mode REUSE (which is the mode
quick_launch uses by default) and launch mode DEFAULT (which is
interpreted as REUSE).

BUG=727837
==========

to

==========
Fix chrome not launching through quick_launch

Previously, chrome only handled launching with launch mode MAKE_NEW.
Now it can also be launched with launch mode REUSE (which is the mode
quick_launch uses by default) and launch mode DEFAULT (which is
interpreted as REUSE).

BUG=727837
==========

[alexanderdai, 2017-05-31 21:58:15]

alexanderdai@chromium.org changed reviewers:
+ sadrul@chromium.org

[alexanderdai, 2017-05-31 22:01:22]

Description was changed from

==========
Fix chrome not launching through quick_launch

Previously, chrome only handled launching with launch mode MAKE_NEW.
Now it can also be launched with launch mode REUSE (which is the mode
quick_launch uses by default) and launch mode DEFAULT (which is
interpreted as REUSE).

BUG=727837
==========

to

==========
Fix chrome not launching through quick_launch

Previously, chrome only handled launching with launch mode MAKE_NEW.
Now it can also be launched with launch mode REUSE (which is the mode
quick_launch uses by default) and launch mode DEFAULT (which is
interpreted as REUSE).

Typing chrome into quick_launch restores focus only to the original 
chrome window; it doesn't restore focus to chrome windows launched
through quick_launch for some reason.

BUG=727837
==========

[sadrul, 2017-06-01 19:32:38]

lgtm

https://codereview.chromium.org/2920473003/diff/1/chrome/browser/chrome_conte...
File chrome/browser/chrome_content_browser_client.cc (right):

https://codereview.chromium.org/2920473003/diff/1/chrome/browser/chrome_conte...
chrome/browser/chrome_content_browser_client.cc:557: how ==
mash::mojom::LaunchMode::DEFAULT;
Instead of checking REUSE or DEFAULT, just check that not MAKE_NEW?

[alexanderdai, 2017-06-01 21:11:33]

https://codereview.chromium.org/2920473003/diff/1/chrome/browser/chrome_conte...
File chrome/browser/chrome_content_browser_client.cc (right):

https://codereview.chromium.org/2920473003/diff/1/chrome/browser/chrome_conte...
chrome/browser/chrome_content_browser_client.cc:557: how ==
mash::mojom::LaunchMode::DEFAULT;
On 2017/06/01 19:32:38, sadrul wrote:
> Instead of checking REUSE or DEFAULT, just check that not MAKE_NEW?

Done.

[alexanderdai, 2017-06-01 21:12:11]

The CQ bit was checked by alexanderdai@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-01 21:12:59]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-01 22:55:24]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-01 22:55:25]

Dry run: This issue passed the CQ dry run.

[alexanderdai, 2017-06-01 23:24:53]

The CQ bit was checked by alexanderdai@chromium.org

[alexanderdai, 2017-06-01 23:24:53]

The patchset sent to the CQ was uploaded after l-g-t-m from sadrul@chromium.org
Link to the patchset: https://codereview.chromium.org/2920473003/#ps20001
(title: "check not MAKE_NEW instead of REUSE or DEFAULT")

[commit-bot: I haz the power, 2017-06-01 23:25:44]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-01 23:31:02]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1496359493139600,
"parent_rev": "3612567b1d18726aa2acc3b477c615f98c016c0a", "commit_rev":
"8ea647a2d24bd0cff32ac9c57cd4edba69eff66e"}

[commit-bot: I haz the power, 2017-06-01 23:31:09]

Description was changed from

==========
Fix chrome not launching through quick_launch

Previously, chrome only handled launching with launch mode MAKE_NEW.
Now it can also be launched with launch mode REUSE (which is the mode
quick_launch uses by default) and launch mode DEFAULT (which is
interpreted as REUSE).

Typing chrome into quick_launch restores focus only to the original 
chrome window; it doesn't restore focus to chrome windows launched
through quick_launch for some reason.

BUG=727837
==========

to

==========
Fix chrome not launching through quick_launch

Previously, chrome only handled launching with launch mode MAKE_NEW.
Now it can also be launched with launch mode REUSE (which is the mode
quick_launch uses by default) and launch mode DEFAULT (which is
interpreted as REUSE).

Typing chrome into quick_launch restores focus only to the original 
chrome window; it doesn't restore focus to chrome windows launched
through quick_launch for some reason.

BUG=727837

Review-Url: https://codereview.chromium.org/2920473003
Cr-Commit-Position: refs/heads/master@{#476482}
Committed:
https://chromium.googlesource.com/chromium/src/+/8ea647a2d24bd0cff32ac9c57cd4...
==========

[commit-bot: I haz the power, 2017-06-01 23:31:10]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/8ea647a2d24bd0cff32ac9c57cd4...