Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(355)

Issue 2920473002: Make tasklist and taskpage use subsecond durations (Closed)

Created:
3 years, 6 months ago by kjlubick
Modified:
3 years, 6 months ago
Reviewers:
KevinL, stephana
CC:
chromium-reviews, infra-reviews+luci-py_chromium.org, M-A Ruel
Target Ref:
refs/heads/master
Project:
luci-py
Visibility:
Public.

Description

Make tasklist and taskpage use subsecond durations subsecond durations are activated when time < 60 seconds. Longer durations likely don't need that. BUG=726717 Review-Url: https://codereview.chromium.org/2920473002 Committed: https://github.com/luci/luci-py/commit/e647c14a2238fa2f8bf10c93771a5c81f703d91a

Patch Set 1 #

Total comments: 3
Unified diffs Side-by-side diffs Delta from patch set Stats (+28 lines, -10 lines) Patch
M appengine/swarming/ui/build/elements.html View 3 chunks +3 lines, -3 lines 0 comments Download
M appengine/swarming/ui/res/imp/common/common-behavior.html View 1 chunk +23 lines, -1 line 3 comments Download
M appengine/swarming/ui/res/imp/tasklist/task-list-data.html View 1 chunk +1 line, -3 lines 0 comments Download
M appengine/swarming/ui/res/imp/taskpage/task-page-data.html View 1 chunk +1 line, -3 lines 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 17 (8 generated)
kjlubick
https://screenshot.googleplex.com/v9f7wi3yV7c See it live at https://2846-5959b7e-tainted-kjlubick-dot-chromium-swarm-dev.appspot.com/task?id=3677a984b6f2a810&refresh=10
3 years, 6 months ago (2017-05-31 14:44:42 UTC) #3
stephana
lgtm modulo one nit https://codereview.chromium.org/2920473002/diff/1/appengine/swarming/ui/res/imp/common/common-behavior.html File appengine/swarming/ui/res/imp/common/common-behavior.html (right): https://codereview.chromium.org/2920473002/diff/1/appengine/swarming/ui/res/imp/common/common-behavior.html#newcode162 appengine/swarming/ui/res/imp/common/common-behavior.html:162: if (timeInSecs === 0 || ...
3 years, 6 months ago (2017-05-31 15:00:43 UTC) #4
kjlubick
https://codereview.chromium.org/2920473002/diff/1/appengine/swarming/ui/res/imp/common/common-behavior.html File appengine/swarming/ui/res/imp/common/common-behavior.html (right): https://codereview.chromium.org/2920473002/diff/1/appengine/swarming/ui/res/imp/common/common-behavior.html#newcode162 appengine/swarming/ui/res/imp/common/common-behavior.html:162: if (timeInSecs === 0 || timeInSecs === "0") { ...
3 years, 6 months ago (2017-05-31 15:02:53 UTC) #5
stephana
https://codereview.chromium.org/2920473002/diff/1/appengine/swarming/ui/res/imp/common/common-behavior.html File appengine/swarming/ui/res/imp/common/common-behavior.html (right): https://codereview.chromium.org/2920473002/diff/1/appengine/swarming/ui/res/imp/common/common-behavior.html#newcode162 appengine/swarming/ui/res/imp/common/common-behavior.html:162: if (timeInSecs === 0 || timeInSecs === "0") { ...
3 years, 6 months ago (2017-05-31 17:29:19 UTC) #6
KevinL
lgtm
3 years, 6 months ago (2017-05-31 18:42:37 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2920473002/1
3 years, 6 months ago (2017-05-31 18:42:44 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: Luci-py Presubmit on luci.infra.try (JOB_FAILED, https://luci-milo.appspot.com/swarming/task/3678a8915496cb10)
3 years, 6 months ago (2017-05-31 18:55:33 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2920473002/1
3 years, 6 months ago (2017-05-31 18:59:43 UTC) #14
commit-bot: I haz the power
3 years, 6 months ago (2017-05-31 19:09:06 UTC) #17
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://github.com/luci/luci-py/commit/e647c14a2238fa2f8bf10c93771a5c81f703d91a

Powered by Google App Engine
This is Rietveld 408576698