Make tasklist and taskpage use subsecond durations

Make tasklist and taskpage use subsecond durations

subsecond durations are activated when time < 60 seconds.
Longer durations likely don't need that.

BUG=726717
Review-Url: https://codereview.chromium.org/2920473002
Committed: https://github.com/luci/luci-py/commit/e647c14a2238fa2f8bf10c93771a5c81f703d91a

[kjlubick, 2017-05-31 14:43:48]

Description was changed from

==========
Make tasklist and taskpage use subsecond durations

BUG=726717
==========

to

==========
Make tasklist and taskpage use subsecond durations

subsecond durations are activated when time < 60 seconds.
Longer durations likely don't need that.

BUG=726717
==========

[kjlubick, 2017-05-31 14:44:38]

kjlubick@google.com changed reviewers:
+ stephana@google.com

[kjlubick, 2017-05-31 14:44:42]

https://screenshot.googleplex.com/v9f7wi3yV7c

See it live at
https://2846-5959b7e-tainted-kjlubick-dot-chromium-swarm-dev.appspot.com/task...

[stephana, 2017-05-31 15:00:43]

lgtm modulo one nit

https://codereview.chromium.org/2920473002/diff/1/appengine/swarming/ui/res/i...
File appengine/swarming/ui/res/imp/common/common-behavior.html (right):

https://codereview.chromium.org/2920473002/diff/1/appengine/swarming/ui/res/i...
appengine/swarming/ui/res/imp/common/common-behavior.html:162: if (timeInSecs
=== 0 || timeInSecs === "0") {
.... timeInSecs === "0" should be omitted IMO. String values can be handled by
the subsequent clauses. If it is '' it will be falsey and otherwise parseFloat
will take care of it.

[kjlubick, 2017-05-31 15:02:53]

https://codereview.chromium.org/2920473002/diff/1/appengine/swarming/ui/res/i...
File appengine/swarming/ui/res/imp/common/common-behavior.html (right):

https://codereview.chromium.org/2920473002/diff/1/appengine/swarming/ui/res/i...
appengine/swarming/ui/res/imp/common/common-behavior.html:162: if (timeInSecs
=== 0 || timeInSecs === "0") {
On 2017/05/31 at 15:00:42, stephana wrote:
> .... timeInSecs === "0" should be omitted IMO. String values can be handled by
the subsequent clauses. If it is '' it will be falsey and otherwise parseFloat
will take care of it.

I put it in there such that 0 and "0" become "0s" Otherwise, the later becomes
"0.00s" and the inconsistency looks strange.

[stephana, 2017-05-31 17:29:19]

https://codereview.chromium.org/2920473002/diff/1/appengine/swarming/ui/res/i...
File appengine/swarming/ui/res/imp/common/common-behavior.html (right):

https://codereview.chromium.org/2920473002/diff/1/appengine/swarming/ui/res/i...
appengine/swarming/ui/res/imp/common/common-behavior.html:162: if (timeInSecs
=== 0 || timeInSecs === "0") {
On 2017/05/31 15:02:53, kjlubick wrote:
> On 2017/05/31 at 15:00:42, stephana wrote:
> > .... timeInSecs === "0" should be omitted IMO. String values can be handled
by
> the subsequent clauses. If it is '' it will be falsey and otherwise parseFloat
> will take care of it.
> 
> I put it in there such that 0 and "0" become "0s" Otherwise, the later becomes
> "0.00s" and the inconsistency looks strange. 

Ack

[KevinL, 2017-05-31 18:42:37]

kjlubick@chromium.org changed reviewers:
+ kjlubick@chromium.org

[KevinL, 2017-05-31 18:42:37]

The CQ bit was checked by kjlubick@chromium.org

[KevinL, 2017-05-31 18:42:37]

lgtm

[commit-bot: I haz the power, 2017-05-31 18:42:44]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-31 18:55:32]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-31 18:55:33]

Try jobs failed on following builders:
  Luci-py Presubmit on luci.infra.try (JOB_FAILED,
https://luci-milo.appspot.com/swarming/task/3678a8915496cb10)

[kjlubick, 2017-05-31 18:59:35]

The CQ bit was checked by kjlubick@google.com

[commit-bot: I haz the power, 2017-05-31 18:59:43]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-31 19:09:03]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1496257175216090, "parent_rev":
"d1129926624daa277d7ec008f871ca981d379556", "commit_rev":
"e647c14a2238fa2f8bf10c93771a5c81f703d91a"}

[commit-bot: I haz the power, 2017-05-31 19:09:05]

Description was changed from

==========
Make tasklist and taskpage use subsecond durations

subsecond durations are activated when time < 60 seconds.
Longer durations likely don't need that.

BUG=726717
==========

to

==========
Make tasklist and taskpage use subsecond durations

subsecond durations are activated when time < 60 seconds.
Longer durations likely don't need that.

BUG=726717

Review-Url: https://codereview.chromium.org/2920473002
Committed:
https://github.com/luci/luci-py/commit/e647c14a2238fa2f8bf10c93771a5c81f703d91a
==========

[commit-bot: I haz the power, 2017-05-31 19:09:06]

Committed patchset #1 (id:1) as
https://github.com/luci/luci-py/commit/e647c14a2238fa2f8bf10c93771a5c81f703d91a