Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(450)

Issue 2920463002: views: remove FocusableRoundedBorderMac (Closed)

Created:
3 years, 6 months ago by Elly Fong-Jones
Modified:
3 years, 6 months ago
Reviewers:
sky
CC:
chromium-reviews, tfarina, mac-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

views: remove FocusableRoundedBorderMac This class was part of the "Shiny Modern" Views UI look, but ended up unused. BUG=None Review-Url: https://codereview.chromium.org/2920463002 Cr-Commit-Position: refs/heads/master@{#476361} Committed: https://chromium.googlesource.com/chromium/src/+/ab458a607fbceeee4a548431fbcd9dfd8d49bdcb

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -75 lines) Patch
M ui/views/BUILD.gn View 1 chunk +0 lines, -2 lines 0 comments Download
D ui/views/controls/focusable_rounded_border_mac.h View 1 chunk +0 lines, -30 lines 0 comments Download
D ui/views/controls/focusable_rounded_border_mac.cc View 1 chunk +0 lines, -43 lines 0 comments Download

Messages

Total messages: 13 (7 generated)
Elly Fong-Jones
sky: ptal? :)
3 years, 6 months ago (2017-05-31 14:35:51 UTC) #3
sky
LGTM
3 years, 6 months ago (2017-05-31 15:45:36 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2920463002/1
3 years, 6 months ago (2017-05-31 16:15:16 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: ios-simulator on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/builds/227364)
3 years, 6 months ago (2017-05-31 17:40:59 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2920463002/1
3 years, 6 months ago (2017-06-01 16:47:08 UTC) #10
commit-bot: I haz the power
3 years, 6 months ago (2017-06-01 18:29:22 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/ab458a607fbceeee4a548431fbcd...

Powered by Google App Engine
This is Rietveld 408576698