Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(194)

Issue 2920403002: Anyone can edit check_gn_headers_whitelist.txt (Closed)

Created:
3 years, 6 months ago by wychen
Modified:
3 years, 6 months ago
Reviewers:
Dirk Pranke
CC:
chromium-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Anyone can edit check_gn_headers_whitelist.txt BUG=661774 Review-Url: https://codereview.chromium.org/2920403002 Cr-Commit-Position: refs/heads/master@{#477338} Committed: https://chromium.googlesource.com/chromium/src/+/1ef74e6c994ef0e20184f79fdf0372ff756e13fd

Patch Set 1 #

Patch Set 2 : add comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -0 lines) Patch
M build/OWNERS View 1 chunk +1 line, -0 lines 0 comments Download
M build/check_gn_headers_whitelist.txt View 1 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (4 generated)
wychen
PTAL
3 years, 6 months ago (2017-06-06 04:36:38 UTC) #2
Dirk Pranke
lgtm
3 years, 6 months ago (2017-06-06 16:46:45 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2920403002/20001
3 years, 6 months ago (2017-06-06 17:49:13 UTC) #5
commit-bot: I haz the power
3 years, 6 months ago (2017-06-06 18:02:31 UTC) #8
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/1ef74e6c994ef0e20184f79fdf03...

Powered by Google App Engine
This is Rietveld 408576698