Implementing answer card hover highlight.

Implementing answer card hover highlight.

Catching WebContents mouse-hover notifications and passing them to
SearchAnswerContainerView to that it knows that the mouse is above the
card.

Bug=712331
Review-Url: https://codereview.chromium.org/2920393002
Cr-Commit-Position: refs/heads/master@{#477389}
Committed: https://chromium.googlesource.com/chromium/src/+/6f511f5c040c7d7443786ca4e34ae40aca9f5377

[vadimt, 2017-06-05 23:51:48]

vadimt@chromium.org changed reviewers:
+ xiyuan@chromium.org

[vadimt, 2017-06-05 23:52:05]

The CQ bit was checked by vadimt@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-05 23:52:51]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-05 23:55:28]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-05 23:55:30]

Dry run: Try jobs failed on following builders:
  ios-device on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)
  ios-simulator-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator-xco...)
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[vadimt, 2017-06-06 00:14:45]

The CQ bit was checked by vadimt@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-06 00:15:33]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-06 00:56:10]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-06 00:56:11]

Dry run: This issue passed the CQ dry run.

[vadimt, 2017-06-06 01:27:42]

The CQ bit was checked by vadimt@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-06 01:28:27]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-06 02:03:24]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-06 02:03:26]

Dry run: This issue passed the CQ dry run.

[xiyuan, 2017-06-06 16:15:17]

https://codereview.chromium.org/2920393002/diff/40001/chrome/browser/ui/app_l...
File chrome/browser/ui/app_list/search/answer_card_search_provider.cc (right):

https://codereview.chromium.org/2920393002/diff/40001/chrome/browser/ui/app_l...
chrome/browser/ui/app_list/search/answer_card_search_provider.cc:99:
rvh->GetWidget()->AddMouseEventCallback(mouse_event_callback_);
Can we move the logic into SearchAnswerContainerView instead?

[vadimt, 2017-06-06 17:40:06]

https://codereview.chromium.org/2920393002/diff/40001/chrome/browser/ui/app_l...
File chrome/browser/ui/app_list/search/answer_card_search_provider.cc (right):

https://codereview.chromium.org/2920393002/diff/40001/chrome/browser/ui/app_l...
chrome/browser/ui/app_list/search/answer_card_search_provider.cc:99:
rvh->GetWidget()->AddMouseEventCallback(mouse_event_callback_);
Then we'll have to pass WebContents to there. SearchResult will become too
specialized since WebContents will need to be passed through it.
(Currently, it passes just views::View)

[xiyuan, 2017-06-06 17:49:42]

https://codereview.chromium.org/2920393002/diff/40001/chrome/browser/ui/app_l...
File chrome/browser/ui/app_list/search/answer_card_search_provider.cc (right):

https://codereview.chromium.org/2920393002/diff/40001/chrome/browser/ui/app_l...
chrome/browser/ui/app_list/search/answer_card_search_provider.cc:99:
rvh->GetWidget()->AddMouseEventCallback(mouse_event_callback_);
On 2017/06/06 17:40:06, vadimt wrote:
> Then we'll have to pass WebContents to there. SearchResult will become too
> specialized since WebContents will need to be passed through it.
> (Currently, it passes just views::View)

SearchResult is supposed to be data. Mouse handling feels more like UI code. 

I would rather do a casting in UI code to convert the views::View* to
views::WebView* then gets the WebContents.

[xiyuan, 2017-06-06 18:53:53]

lgtm with nits

per offline discussion, let's defer the refactoring work.

https://codereview.chromium.org/2920393002/diff/40001/ui/app_list/search_resu...
File ui/app_list/search_result.h (right):

https://codereview.chromium.org/2920393002/diff/40001/ui/app_list/search_resu...
ui/app_list/search_result.h:120: void set_is_mouse_in_view(bool
mouse_is_inside);
nit: set_is_mouse_in_view -> SetIsMouseInView since it is not just an accessor.

https://codereview.chromium.org/2920393002/diff/40001/ui/app_list/search_resu...
File ui/app_list/search_result_observer.h (right):

https://codereview.chromium.org/2920393002/diff/40001/ui/app_list/search_resu...
ui/app_list/search_result_observer.h:36: // enters or exits that view.
nit: Document that it is needed because the view is views::WebView and existing
views mouse enter/exit events does not fire on it.

[vadimt, 2017-06-06 19:02:32]

Description was changed from

==========
Implementing answer card hover highlight.

Catching WebContents mouse-hover notifications and passing them to
SearchAnswerContainerView to that it knows that the maouse is obove the
card.

Bug=712331
==========

to

==========
Implementing answer card hover highlight.

Catching WebContents mouse-hover notifications and passing them to
SearchAnswerContainerView to that it knows that the mouse is above the
card.

Bug=712331
==========

[vadimt, 2017-06-06 19:18:54]

https://codereview.chromium.org/2920393002/diff/40001/ui/app_list/search_resu...
File ui/app_list/search_result.h (right):

https://codereview.chromium.org/2920393002/diff/40001/ui/app_list/search_resu...
ui/app_list/search_result.h:120: void set_is_mouse_in_view(bool
mouse_is_inside);
On 2017/06/06 18:53:52, xiyuan wrote:
> nit: set_is_mouse_in_view -> SetIsMouseInView since it is not just an
accessor.

Done.

https://codereview.chromium.org/2920393002/diff/40001/ui/app_list/search_resu...
File ui/app_list/search_result_observer.h (right):

https://codereview.chromium.org/2920393002/diff/40001/ui/app_list/search_resu...
ui/app_list/search_result_observer.h:36: // enters or exits that view.
On 2017/06/06 18:53:53, xiyuan wrote:
> nit: Document that it is needed because the view is views::WebView and
existing
> views mouse enter/exit events does not fire on it.

Done.

[vadimt, 2017-06-06 19:19:03]

The CQ bit was checked by vadimt@chromium.org

[vadimt, 2017-06-06 19:19:03]

The patchset sent to the CQ was uploaded after l-g-t-m from xiyuan@chromium.org
Link to the patchset: https://codereview.chromium.org/2920393002/#ps60001
(title: "CR comments")

[commit-bot: I haz the power, 2017-06-06 19:19:35]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-06 20:27:34]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1496776743068000,
"parent_rev": "1cfb38a9685f1e8561435982acbe797912cdb9e1", "commit_rev":
"6f511f5c040c7d7443786ca4e34ae40aca9f5377"}

[commit-bot: I haz the power, 2017-06-06 20:27:46]

Description was changed from

==========
Implementing answer card hover highlight.

Catching WebContents mouse-hover notifications and passing them to
SearchAnswerContainerView to that it knows that the mouse is above the
card.

Bug=712331
==========

to

==========
Implementing answer card hover highlight.

Catching WebContents mouse-hover notifications and passing them to
SearchAnswerContainerView to that it knows that the mouse is above the
card.

Bug=712331

Review-Url: https://codereview.chromium.org/2920393002
Cr-Commit-Position: refs/heads/master@{#477389}
Committed:
https://chromium.googlesource.com/chromium/src/+/6f511f5c040c7d7443786ca4e34a...
==========

[commit-bot: I haz the power, 2017-06-06 20:27:47]

Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/6f511f5c040c7d7443786ca4e34a...