Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7)

Issue 2920323002: Fix the test and implement forEachOverridePair() for IncrementalClassHierarchy. (Closed)

Created:
3 years, 6 months ago by scheglov
Modified:
3 years, 6 months ago
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Fix the test and implement forEachOverridePair() for IncrementalClassHierarchy. R=ahe@google.com, kmillikin@google.com, paulberry@google.com, sigmund@google.com BUG= Committed: https://github.com/dart-lang/sdk/commit/64ce51ce4bc3aa4248dba87c44775c9b84bd2b5d

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+67 lines, -21 lines) Patch
M pkg/kernel/lib/src/incremental_class_hierarchy.dart View 2 chunks +61 lines, -3 lines 0 comments Download
M pkg/kernel/test/class_hierarchy_test.dart View 3 chunks +6 lines, -18 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
scheglov
3 years, 6 months ago (2017-06-05 17:59:57 UTC) #1
Paul Berry
lgtm
3 years, 6 months ago (2017-06-05 18:24:50 UTC) #2
scheglov
3 years, 6 months ago (2017-06-05 20:11:35 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
64ce51ce4bc3aa4248dba87c44775c9b84bd2b5d (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698