Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(72)

Unified Diff: pkg/kernel/test/class_hierarchy_test.dart

Issue 2920323002: Fix the test and implement forEachOverridePair() for IncrementalClassHierarchy. (Closed)
Patch Set: Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « pkg/kernel/lib/src/incremental_class_hierarchy.dart ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/kernel/test/class_hierarchy_test.dart
diff --git a/pkg/kernel/test/class_hierarchy_test.dart b/pkg/kernel/test/class_hierarchy_test.dart
index 055ce43427e005a795dfbfa7e872185b7a35b4f1..8cb8fa97d937a8484950d8c3207e0e64968e7a52 100644
--- a/pkg/kernel/test/class_hierarchy_test.dart
+++ b/pkg/kernel/test/class_hierarchy_test.dart
@@ -31,21 +31,6 @@ class IncrementalClassHierarchyTest extends _ClassHierarchyTest {
ClassHierarchy createClassHierarchy(Program program) {
return new IncrementalClassHierarchy();
}
-
- @failingTest
- void test_forEachOverridePair_supertypeOverridesInterface() {
- super.test_forEachOverridePair_supertypeOverridesInterface();
- }
-
- @failingTest
- void test_forEachOverridePair_thisOverridesSupertype() {
- super.test_forEachOverridePair_thisOverridesSupertype();
- }
-
- @failingTest
- void test_forEachOverridePair_thisOverridesSupertype_setter() {
- super.test_forEachOverridePair_thisOverridesSupertype_setter();
- }
}
abstract class _ClassHierarchyTest {
@@ -178,8 +163,6 @@ class E = self::D with self::A implements self::B {}
/// 3. A non-abstract member is inherited from a superclass, and it overrides
/// an abstract member declared in this class.
- /// TODO(scheglov): Implementation does not follow the documentation.
- @failingTest
void test_forEachOverridePair_supertypeOverridesThisAbstract() {
var a = addClass(new Class(
name: 'A',
@@ -200,7 +183,12 @@ class B extends self::A {
}
''');
- _assertOverridePairs(b, ['test::A::foo overrides test::B::foo']);
+ // The documentation says:
+ // It is possible for two methods to override one another in both directions.
+ _assertOverridePairs(b, [
+ 'test::A::foo overrides test::B::foo',
+ 'test::B::foo overrides test::A::foo'
+ ]);
}
/// 1. A member declared in the class overrides a member inheritable through
« no previous file with comments | « pkg/kernel/lib/src/incremental_class_hierarchy.dart ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698