Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(206)

Issue 2920303002: Add a NotificationTemplateBuilder for Action Center toasts (Closed)

Created:
3 years, 6 months ago by Peter Beverloo
Modified:
3 years, 6 months ago
CC:
chromium-reviews, Peter Beverloo, mlamouri+watch-notifications_chromium.org, awdf+watch_chromium.org, picksi1
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Add a NotificationTemplateBuilder for Action Center toasts This adds a notification template builder that takes a notification_id and a message_center::Notification object and builds the XML template that can be displayed using the Windows Action Center. It's functionality is incredibly limited -- the title, message and origin attribution of a notification are included, everything else will have to be added in the future. BUG=734095 Review-Url: https://codereview.chromium.org/2920303002 Cr-Commit-Position: refs/heads/master@{#480097} Committed: https://chromium.googlesource.com/chromium/src/+/5904da760ad0345a34a986601f6ae26fb78a4a2e

Patch Set 1 #

Total comments: 11

Patch Set 2 : Add a NotificationTemplateBuilder for Action Center toasts #

Patch Set 3 : remove libxml usage from the test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+298 lines, -0 lines) Patch
M chrome/browser/BUILD.gn View 1 1 chunk +2 lines, -0 lines 0 comments Download
A chrome/browser/notifications/notification_template_builder.h View 1 1 chunk +73 lines, -0 lines 0 comments Download
A chrome/browser/notifications/notification_template_builder.cc View 1 chunk +126 lines, -0 lines 0 comments Download
A chrome/browser/notifications/notification_template_builder_unittest.cc View 1 2 1 chunk +96 lines, -0 lines 0 comments Download
M chrome/test/BUILD.gn View 1 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 16 (10 generated)
Peter Beverloo
+finnur for Windows notifications +dominicc for libxml usage I'll update the BUILD.gn files once you're ...
3 years, 6 months ago (2017-06-05 17:06:26 UTC) #2
Finnur
Yesterday was a holiday (Whit Monday). CL LGTM, with minor nits. https://codereview.chromium.org/2920303002/diff/1/chrome/browser/notifications/notification_template_builder.cc File chrome/browser/notifications/notification_template_builder.cc (right): ...
3 years, 6 months ago (2017-06-06 11:00:10 UTC) #7
dominicc (has gone to gerrit)
LGTM At some point someone will come to change or remove XmlReader and/or XmlWriter, but ...
3 years, 6 months ago (2017-06-12 03:40:33 UTC) #8
Peter Beverloo
Thanks both! I've applied the changes, made this Windows-only in BUILD.gn, so let's land it. ...
3 years, 6 months ago (2017-06-16 15:40:21 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2920303002/40001
3 years, 6 months ago (2017-06-16 16:00:37 UTC) #13
commit-bot: I haz the power
3 years, 6 months ago (2017-06-16 17:58:08 UTC) #16
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/5904da760ad0345a34a986601f6a...

Powered by Google App Engine
This is Rietveld 408576698