Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(34)

Issue 2920273002: Disable NTP URL bar while in VR on Android. (Closed)

Created:
3 years, 6 months ago by mthiesse
Modified:
3 years, 6 months ago
Reviewers:
CC:
chromium-reviews
Target Ref:
refs/branch-heads/3112
Project:
chromium
Visibility:
Public.

Description

Disable NTP URL bar while in VR on Android. Unfortunately we don't support keyboard or microphone input while in VR just yet, so we need to disable them to prevent the 2D popups from obscuring VR content. BUG=724551 Review-Url: https://codereview.chromium.org/2891423002 Cr-Original-Commit-Position: refs/heads/master@{#476779} Review-Url: https://codereview.chromium.org/2920273002 . Cr-Commit-Position: refs/branch-heads/3112@{#150} Cr-Branched-From: b6460e24cf59f429d69de255538d0fc7a425ccf9-refs/heads/master@{#474897} Committed: https://chromium.googlesource.com/chromium/src/+/69cdab9ff3cb9593b1155a8cbc5edd8f5c4c31c3

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPage.java View 2 chunks +2 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
mthiesse
3 years, 6 months ago (2017-06-05 14:27:39 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
69cdab9ff3cb9593b1155a8cbc5edd8f5c4c31c3.

Powered by Google App Engine
This is Rietveld 408576698