Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2249)

Unified Diff: pkg/compiler/lib/src/closure.dart

Issue 2920253004: Revert "Revert "Make ClosureTask only accept Element-level APIs instead of resolvedAst."" (Closed)
Patch Set: fix teh tests Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/compiler/lib/src/closure.dart
diff --git a/pkg/compiler/lib/src/closure.dart b/pkg/compiler/lib/src/closure.dart
index e19c69c27acebcdbd395159f8c37bd0dcb5e8c09..6dacea63154b7b81b3c29e4ce148533d4e327ae1 100644
--- a/pkg/compiler/lib/src/closure.dart
+++ b/pkg/compiler/lib/src/closure.dart
@@ -42,26 +42,23 @@ class ClosureTask extends CompilerTask implements ClosureClassMaps {
DiagnosticReporter get reporter => compiler.reporter;
ClosureClassMap getMemberMap(MemberElement member) {
- return getClosureToClassMapping(member.resolvedAst);
+ return getClosureToClassMapping(member);
}
ClosureClassMap getLocalFunctionMap(LocalFunctionElement localFunction) {
- return getClosureToClassMapping(localFunction.resolvedAst);
+ return getClosureToClassMapping(localFunction);
}
/// Returns the [ClosureClassMap] computed for [resolvedAst].
- ClosureClassMap getClosureToClassMapping(ResolvedAst resolvedAst) {
+ ClosureClassMap getClosureToClassMapping(Element element) {
return measure(() {
- Element element = resolvedAst.element;
if (element.isGenerativeConstructorBody) {
ConstructorBodyElement constructorBody = element;
element = constructorBody.constructor;
}
ClosureClassMap closureClassMap = _closureMappingCache[element];
- assert(
- closureClassMap != null,
- failedAt(resolvedAst.element,
- "No ClosureClassMap computed for ${element}."));
+ assert(closureClassMap != null,
+ failedAt(element, "No ClosureClassMap computed for ${element}."));
return closureClassMap;
});
}
@@ -78,23 +75,22 @@ class ClosureTask extends CompilerTask implements ClosureClassMaps {
// Skip top-level/static fields without an initializer.
return;
}
- computeClosureToClassMapping(resolvedAst, closedWorldRefiner);
+ computeClosureToClassMapping(element, closedWorldRefiner);
});
}
ClosureClassMap computeClosureToClassMapping(
- ResolvedAst resolvedAst, ClosedWorldRefiner closedWorldRefiner) {
+ AstElement element, ClosedWorldRefiner closedWorldRefiner) {
return measure(() {
- Element element = resolvedAst.element;
ClosureClassMap cached = _closureMappingCache[element];
if (cached != null) return cached;
- if (resolvedAst.kind != ResolvedAstKind.PARSED) {
+ if (element.resolvedAst.kind != ResolvedAstKind.PARSED) {
return _closureMappingCache[element] =
new ClosureClassMap(null, null, null, new ThisLocal(element));
}
return reporter.withCurrentElement(element.implementation, () {
- Node node = resolvedAst.node;
- TreeElements elements = resolvedAst.elements;
+ Node node = element.resolvedAst.node;
+ TreeElements elements = element.resolvedAst.elements;
ClosureTranslator translator = new ClosureTranslator(
compiler, closedWorldRefiner, elements, _closureMappingCache);
@@ -111,7 +107,7 @@ class ClosureTask extends CompilerTask implements ClosureClassMaps {
} else {
assert(element.isField,
failedAt(element, "Expected $element to be a field."));
- Node initializer = resolvedAst.body;
+ Node initializer = element.resolvedAst.body;
if (initializer != null) {
// The lazy initializer of a static.
translator.translateLazyInitializer(element, node, initializer);
@@ -1139,6 +1135,7 @@ class ClosureTranslator extends Visitor {
compiler.backend.rtiNeed.methodNeedsRti(element);
}
}
+ closureMappingCache[element] = closureData;
closureMappingCache[element.declaration] = closureData;
if (closureData.callElement != null) {
closureMappingCache[closureData.callElement] = closureData;
« no previous file with comments | « no previous file | pkg/compiler/lib/src/dump_info.dart » ('j') | tests/compiler/dart2js/serialization/model_test_helper.dart » ('J')

Powered by Google App Engine
This is Rietveld 408576698