Declare kAppendWholeFile as constexpr

Declare kAppendWholeFile as constexpr

kAppendWholeFile was dynamically initialized, causing it to be 0 at the
time of the initialization of the kMediaSourceADTSTests array when
built with VC 2015.  This resulted in an assertion failure in
MockMediaSource constructor.

std::numeric_limits::max() is constexpr in C++11, so fix that by
declaring kAppendWholeFile as constexpr too.

While we're here, let's change DCHECKs in mock_media_source.cc to
CHECKS, because there is no reason to prefer DCHECK over CHECK in
test-only code.

TEST=media_unittests --gtest_filter=ProprietaryCodecs/BasicMSEPlaybackTest.PlayToEnd/*

Review-Url: https://codereview.chromium.org/2920243002
Cr-Commit-Position: refs/heads/master@{#477755}
Committed: https://chromium.googlesource.com/chromium/src/+/1250a508840b955c6e96eae698cf9783ec1f39d7

[wdzierzanowski, 2017-06-05 10:27:52]

wdzierzanowski@opera.com changed reviewers:
+ xjz@chromium.org

[wdzierzanowski, 2017-06-05 10:27:53]

Hi!

I think this regressed in https://codereview.chromium.org/2808583002. What do
you think about this fix?

[wdzierzanowski, 2017-06-06 13:05:31]

Description was changed from

==========
Declare kAppendWholeFile as constexpr

kAppendWholeFile was dynamically initialized, causing it to be 0 at the
time of the initialization of the kMediaSourceADTSTests array when
built with VC 2015.  This resulted in an assertion failure in
MockMediaSource constructor.

std::numeric_limits::max() is constexpr in C++11, so fix that by
declaring kAppendWholeFile as constexpr too.

While we're here, let's change DCHECKs in mock_media_source.cc to
CHECKS, because there is no reason to prefer DCHECK over CHECK in
test-only code.

TEST=media_unittests
--gtest_filter=ProprietaryCodecs/BasicMSEPlaybackTest.PlayToEnd/*
==========

to

==========
Declare kAppendWholeFile as constexpr

kAppendWholeFile was dynamically initialized, causing it to be 0 at the
time of the initialization of the kMediaSourceADTSTests array when
built with VC 2015.  This resulted in an assertion failure in
MockMediaSource constructor.

std::numeric_limits::max() is constexpr in C++11, so fix that by
declaring kAppendWholeFile as constexpr too.

While we're here, let's change DCHECKs in mock_media_source.cc to
CHECKS, because there is no reason to prefer DCHECK over CHECK in
test-only code.

TEST=media_unittests
--gtest_filter=ProprietaryCodecs/BasicMSEPlaybackTest.PlayToEnd/*
==========

[wdzierzanowski, 2017-06-06 13:05:31]

wdzierzanowski@opera.com changed reviewers:
+ xhwang@chromium.org

[xhwang, 2017-06-07 05:05:54]

xhwang@chromium.org changed reviewers:
+ wolenetz@chromium.org

[xhwang, 2017-06-07 05:05:55]

looking good, but I'd like to defer to wolenetz@ to take a look as well

[xhwang, 2017-06-07 05:06:08]

xhwang@chromium.org changed reviewers:
- xhwang@chromium.org

[wolenetz, 2017-06-07 18:25:51]

LGTM % link in the CL description the relevant crbug, if any (I assume VC 2015
failures were cropping up on bots. If not, how did this issue get found?)

Regardless, thanks for fixing this!

[wolenetz, 2017-06-07 18:26:07]

The CQ bit was checked by wolenetz@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-07 18:26:30]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[wdzierzanowski, 2017-06-07 19:28:11]

I could find no crbug for this.  I can make one if it's needed.

I actually found this issue when running a Debug build of media_unittests for
Opera. Do the bots run media_unittests built with dcheck_always_on=1?

[wolenetz, 2017-06-07 19:29:28]

On 2017/06/07 19:28:11, wdzierzanowski wrote:
> I could find no crbug for this.  I can make one if it's needed.
> 
> I actually found this issue when running a Debug build of media_unittests for
> Opera. Do the bots run media_unittests built with dcheck_always_on=1?

Ah - probably they don't -- good catch. no crbug is required -- I was just
curious.

[wdzierzanowski, 2017-06-07 19:31:56]

OK. Thanks for reviewing!

[xjz, 2017-06-07 20:21:27]

lgtm

[commit-bot: I haz the power, 2017-06-07 20:33:08]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-07 20:33:09]

Dry run: This issue passed the CQ dry run.

[wdzierzanowski, 2017-06-07 20:33:56]

The CQ bit was checked by wdzierzanowski@opera.com

[commit-bot: I haz the power, 2017-06-07 20:34:46]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-07 20:47:38]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1496867636458850, "parent_rev":
"81f90ea81c1e46f8e20f84e0449f397d19f809c8", "commit_rev":
"1250a508840b955c6e96eae698cf9783ec1f39d7"}

[commit-bot: I haz the power, 2017-06-07 20:48:08]

Description was changed from

==========
Declare kAppendWholeFile as constexpr

kAppendWholeFile was dynamically initialized, causing it to be 0 at the
time of the initialization of the kMediaSourceADTSTests array when
built with VC 2015.  This resulted in an assertion failure in
MockMediaSource constructor.

std::numeric_limits::max() is constexpr in C++11, so fix that by
declaring kAppendWholeFile as constexpr too.

While we're here, let's change DCHECKs in mock_media_source.cc to
CHECKS, because there is no reason to prefer DCHECK over CHECK in
test-only code.

TEST=media_unittests
--gtest_filter=ProprietaryCodecs/BasicMSEPlaybackTest.PlayToEnd/*
==========

to

==========
Declare kAppendWholeFile as constexpr

kAppendWholeFile was dynamically initialized, causing it to be 0 at the
time of the initialization of the kMediaSourceADTSTests array when
built with VC 2015.  This resulted in an assertion failure in
MockMediaSource constructor.

std::numeric_limits::max() is constexpr in C++11, so fix that by
declaring kAppendWholeFile as constexpr too.

While we're here, let's change DCHECKs in mock_media_source.cc to
CHECKS, because there is no reason to prefer DCHECK over CHECK in
test-only code.

TEST=media_unittests
--gtest_filter=ProprietaryCodecs/BasicMSEPlaybackTest.PlayToEnd/*

Review-Url: https://codereview.chromium.org/2920243002
Cr-Commit-Position: refs/heads/master@{#477755}
Committed:
https://chromium.googlesource.com/chromium/src/+/1250a508840b955c6e96eae698cf...
==========

[commit-bot: I haz the power, 2017-06-07 20:48:09]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/1250a508840b955c6e96eae698cf...