Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2920223010:
telemetry: Add --browser-executable for 'exact'. (Closed)
Descriptiontelemetry: Add --browser-executable for 'exact'.
BUG=chromium:704681
Review-Url: https://codereview.chromium.org/2920223010
Committed: https://chromium.googlesource.com/external/github.com/catapult-project/catapult/+/4ef4b9509fe15a757ad506be6bac48070eb945d3
Patch Set 1 #
Total comments: 2
Patch Set 2 : . #Messages
Total messages: 18 (13 generated)
The CQ bit was checked by sadrul@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: Catapult Presubmit on master.tryserver.client.catapult (JOB_FAILED, https://build.chromium.org/p/tryserver.client.catapult/builders/Catapult%20Pr...)
sadrul@chromium.org changed reviewers: + nednguyen@google.com
Description was changed from ========== telemetry: Add --browser-executable for 'exact'. BUG=704681 ========== to ========== telemetry: Add --browser-executable for 'exact'. BUG=chrome:704681 ==========
Description was changed from ========== telemetry: Add --browser-executable for 'exact'. BUG=chrome:704681 ========== to ========== telemetry: Add --browser-executable for 'exact'. BUG=chromium:704681 ==========
lgtm with nits https://codereview.chromium.org/2920223010/diff/1/telemetry/telemetry/record_... File telemetry/telemetry/record_wpr_unittest.py (right): https://codereview.chromium.org/2920223010/diff/1/telemetry/telemetry/record_... telemetry/telemetry/record_wpr_unittest.py:150: flags += ['--browser-executable', finder_options.browser_executable] I think you can just remove line 148, 149 & replace with "flags += ['--browser-executable', self._test_options.browser_executable]"
The CQ bit was checked by sadrul@chromium.org to run a CQ dry run
https://codereview.chromium.org/2920223010/diff/1/telemetry/telemetry/record_... File telemetry/telemetry/record_wpr_unittest.py (right): https://codereview.chromium.org/2920223010/diff/1/telemetry/telemetry/record_... telemetry/telemetry/record_wpr_unittest.py:150: flags += ['--browser-executable', finder_options.browser_executable] On 2017/06/08 04:24:10, nednguyen wrote: > I think you can just remove line 148, 149 & replace with "flags += > ['--browser-executable', self._test_options.browser_executable]" You are right. Thanks! Done.
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was checked by sadrul@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from nednguyen@google.com Link to the patchset: https://codereview.chromium.org/2920223010/#ps20001 (title: ".")
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 20001, "attempt_start_ts": 1497036012475260,
"parent_rev": "1ffc3ed0526747eded946b2970a50046603b9272", "commit_rev":
"4ef4b9509fe15a757ad506be6bac48070eb945d3"}
Message was sent while issue was closed.
Description was changed from ========== telemetry: Add --browser-executable for 'exact'. BUG=chromium:704681 ========== to ========== telemetry: Add --browser-executable for 'exact'. BUG=chromium:704681 Review-Url: https://codereview.chromium.org/2920223010 Committed: https://chromium.googlesource.com/external/github.com/catapult-project/catapu... ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as https://chromium.googlesource.com/external/github.com/catapult-project/catapu... |
