Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(305)

Issue 2920223007: [WebVR] Only count devices that have successfully connected. (Closed)

Created:
3 years, 6 months ago by amp
Modified:
3 years, 6 months ago
Reviewers:
mthiesse
CC:
chromium-reviews
Target Ref:
refs/branch-heads/3112
Project:
chromium
Visibility:
Public.

Description

[WebVR] Only count devices that have successfully connected. This allows the navigator.GetVRDisplays() promise to resolve when the underlying VR libraries are not installed or out of date. BUG=727969 NOTRY=true NOPRESUBMIT=true Review-Url: https://codereview.chromium.org/2915993004 Cr-Original-Commit-Position: refs/heads/master@{#476516} Review-Url: https://codereview.chromium.org/2920223007 Cr-Commit-Position: refs/branch-heads/3112@{#185} Cr-Branched-From: b6460e24cf59f429d69de255538d0fc7a425ccf9-refs/heads/master@{#474897} Committed: https://chromium.googlesource.com/chromium/src/+/b4d2ab94fc1760c766538b48abaad800dbc9b575

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -5 lines) Patch
M device/vr/vr_service_impl.h View 1 chunk +1 line, -0 lines 0 comments Download
M device/vr/vr_service_impl.cc View 3 chunks +8 lines, -5 lines 0 comments Download

Messages

Total messages: 9 (5 generated)
amp
drover merge to 60
3 years, 6 months ago (2017-06-06 15:52:26 UTC) #3
mthiesse
lgtm
3 years, 6 months ago (2017-06-06 16:11:34 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2920223007/1
3 years, 6 months ago (2017-06-06 16:17:08 UTC) #6
commit-bot: I haz the power
3 years, 6 months ago (2017-06-06 16:17:41 UTC) #9
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/b4d2ab94fc1760c766538b48abaa...

Powered by Google App Engine
This is Rietveld 408576698