Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(200)

Issue 2920223003: Disable failing navigation callbacks test (Closed)

Created:
3 years, 6 months ago by PL
Modified:
3 years, 6 months ago
Reviewers:
kkhorimoto
CC:
chromium-reviews, Eugene But (OOO till 7-30), ios-reviews+web_chromium.org, ios-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Disable failing navigation callbacks test. This disables tests that are causing NavigationCallbackTests to fail on device when running iOS 9.3. It's not trivial to revert the original change that introduced these tests as it has since been built upon. BUG=729602 Review-Url: https://codereview.chromium.org/2920223003 Cr-Commit-Position: refs/heads/master@{#477032} Committed: https://chromium.googlesource.com/chromium/src/+/80b9d5901a3f624a7c8ef8bd486cfcb532633172

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -3 lines) Patch
M ios/web/web_state/navigation_callbacks_inttest.mm View 3 chunks +21 lines, -3 lines 0 comments Download

Messages

Total messages: 15 (10 generated)
PL
Hello Kurt! With Eugene OOO, would you be able to review the disabling of these ...
3 years, 6 months ago (2017-06-05 16:45:37 UTC) #5
kkhorimoto
lgtm, but can you update the CL description to limit line length to 72 characters?
3 years, 6 months ago (2017-06-05 17:04:04 UTC) #8
PL
On 2017/06/05 17:04:04, kkhorimoto_ wrote: > lgtm, but can you update the CL description to ...
3 years, 6 months ago (2017-06-05 18:05:27 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2920223003/1
3 years, 6 months ago (2017-06-05 18:06:55 UTC) #12
commit-bot: I haz the power
3 years, 6 months ago (2017-06-05 18:12:23 UTC) #15
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/80b9d5901a3f624a7c8ef8bd486c...

Powered by Google App Engine
This is Rietveld 408576698