Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(150)

Issue 2920193004: [turbofan] Improve representation selection for type guard. (Closed)

Created:
3 years, 6 months ago by Jarin
Modified:
3 years, 6 months ago
Reviewers:
Benedikt Meurer
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Improve representation selection for type guard. This takes into account the type of the type guard when choosing representation for a node. To make the representation changes unambiguous, we pass the restricted type to the changer. BUG=chromium:726554 Review-Url: https://codereview.chromium.org/2920193004 Cr-Commit-Position: refs/heads/master@{#45734} Committed: https://chromium.googlesource.com/v8/v8/+/5005faed5cd4890dd2eb28384f09e68b10d07df2

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+50 lines, -12 lines) Patch
M src/compiler/simplified-lowering.cc View 3 chunks +23 lines, -12 lines 0 comments Download
A test/mjsunit/compiler/regress-726554.js View 1 chunk +27 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (8 generated)
Jarin
Could you take a look, please?
3 years, 6 months ago (2017-06-06 14:00:57 UTC) #4
Benedikt Meurer
lgtm
3 years, 6 months ago (2017-06-06 14:02:28 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2920193004/1
3 years, 6 months ago (2017-06-06 14:44:24 UTC) #9
commit-bot: I haz the power
3 years, 6 months ago (2017-06-06 14:45:36 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/v8/v8/+/5005faed5cd4890dd2eb28384f09e68b10d...

Powered by Google App Engine
This is Rietveld 408576698