Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(180)

Issue 2920193003: Move "word" granularity related functions to VisibleUnitWord.cpp (Closed)

Created:
3 years, 6 months ago by yosin_UTC9
Modified:
3 years, 6 months ago
Reviewers:
yoichio, Xiaocheng
CC:
blink-reviews, chromium-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Move "word" granularity related functions to VisibleUnitWord.cpp This patch moves "word" granularity related functions to "VisibleUnitWord.cpp" for ease of adopting them to Layout NG. This patch is similar to the patch[1] which move "line" granularity related functions to "VisibleUnitLine.cpp" [1] http://crrev.com/2914793002: Move "line" granularity related functions to VisibleUnitLine.cpp BUG=707656 TEST=n/a; no behavior changes Review-Url: https://codereview.chromium.org/2920193003 Cr-Commit-Position: refs/heads/master@{#477913} Committed: https://chromium.googlesource.com/chromium/src/+/f5fb415739fdd30d61a3507ccd624553c8f46eef

Patch Set 1 : 2017-06-06T15:53:22 #

Patch Set 2 : 2017-06-07T11:28:29 #

Total comments: 2

Patch Set 3 : 2017-06-08T12:52:45 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+245 lines, -168 lines) Patch
M third_party/WebKit/Source/core/editing/BUILD.gn View 1 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/editing/VisibleUnits.h View 1 chunk +18 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/editing/VisibleUnits.cpp View 1 2 3 chunks +16 lines, -168 lines 0 comments Download
A third_party/WebKit/Source/core/editing/VisibleUnitsWord.cpp View 1 2 1 chunk +210 lines, -0 lines 0 comments Download

Messages

Total messages: 22 (16 generated)
yosin_UTC9
PTAL
3 years, 6 months ago (2017-06-07 03:09:46 UTC) #9
Xiaocheng
https://codereview.chromium.org/2920193003/diff/20001/third_party/WebKit/Source/core/editing/VisibleUnits.cpp File third_party/WebKit/Source/core/editing/VisibleUnits.cpp (left): https://codereview.chromium.org/2920193003/diff/20001/third_party/WebKit/Source/core/editing/VisibleUnits.cpp#oldcode531 third_party/WebKit/Source/core/editing/VisibleUnits.cpp:531: // --------- Functions above this line shouldn't be moved. ...
3 years, 6 months ago (2017-06-07 17:45:39 UTC) #12
yosin_UTC9
PTAL https://codereview.chromium.org/2920193003/diff/20001/third_party/WebKit/Source/core/editing/VisibleUnits.cpp File third_party/WebKit/Source/core/editing/VisibleUnits.cpp (left): https://codereview.chromium.org/2920193003/diff/20001/third_party/WebKit/Source/core/editing/VisibleUnits.cpp#oldcode531 third_party/WebKit/Source/core/editing/VisibleUnits.cpp:531: // --------- On 2017/06/07 at 17:45:38, Xiaocheng wrote: ...
3 years, 6 months ago (2017-06-08 04:09:14 UTC) #15
Xiaocheng
lgtm
3 years, 6 months ago (2017-06-08 05:37:10 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2920193003/40001
3 years, 6 months ago (2017-06-08 05:43:55 UTC) #19
commit-bot: I haz the power
3 years, 6 months ago (2017-06-08 06:20:58 UTC) #22
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/f5fb415739fdd30d61a3507ccd62...

Powered by Google App Engine
This is Rietveld 408576698