Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(457)

Issue 2920183003: DevTools: allow setting individual console filter levels. (Closed)

Created:
3 years, 6 months ago by pfeldman
Modified:
3 years, 6 months ago
Reviewers:
dgozman, alph, PhistucK
CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, pfeldman, kozyatinskiy+blink_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

DevTools: allow setting individual console filter levels. Review-Url: https://codereview.chromium.org/2920183003 Cr-Commit-Position: refs/heads/master@{#477444} Committed: https://chromium.googlesource.com/chromium/src/+/1369587070df8d40fb8bffffca8ef525be19616e

Patch Set 1 #

Patch Set 2 : with tests #

Total comments: 1

Messages

Total messages: 12 (5 generated)
pfeldman
3 years, 6 months ago (2017-06-06 17:34:31 UTC) #2
alph
Would be nice to have a bug # and a screenshot
3 years, 6 months ago (2017-06-06 18:59:55 UTC) #4
dgozman
lgtm https://codereview.chromium.org/2920183003/diff/10002/third_party/WebKit/Source/devtools/front_end/console/ConsoleView.js File third_party/WebKit/Source/devtools/front_end/console/ConsoleView.js (right): https://codereview.chromium.org/2920183003/diff/10002/third_party/WebKit/Source/devtools/front_end/console/ConsoleView.js#newcode1033 third_party/WebKit/Source/devtools/front_end/console/ConsoleView.js:1033: this._levelMenuButtonArrow = new UI.ToolbarItem(UI.Icon.create('smallicon-triangle-down')); Oh my...
3 years, 6 months ago (2017-06-06 19:02:46 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2920183003/10002
3 years, 6 months ago (2017-06-06 20:30:36 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:10002) as https://chromium.googlesource.com/chromium/src/+/1369587070df8d40fb8bffffca8ef525be19616e
3 years, 6 months ago (2017-06-06 22:40:11 UTC) #10
PhistucK
Can you merge this to Chrome 60 (and 59, but that will probably not happen)?
3 years, 6 months ago (2017-06-09 13:01:35 UTC) #11
wOxxOm
3 years, 6 months ago (2017-06-15 09:35:11 UTC) #12
Message was sent while issue was closed.
This is great! One nitpick though: the black checkmark icon inside the filter
dropdown is almost invisible when the dark devtools UI theme is selected in
devtools settings.

Powered by Google App Engine
This is Rietveld 408576698