Tidy up SVGListPropertyHelper

Tidy up SVGListPropertyHelper

Turn some iterations into range-based for-loops. Use operator== from
Vector<...> rather than re-implementing it. Remove FindItem (unused.)
Deduplicate some code, replace 0 with nullptr where appropriate and
simplify the padding loop.

BUG=709001
Review-Url: https://codereview.chromium.org/2920103002
Cr-Commit-Position: refs/heads/master@{#476914}
Committed: https://chromium.googlesource.com/chromium/src/+/5f488b372798d523f0b6b48f6eec7efa6bf53500

[fs, 2017-06-03 17:19:07]

The CQ bit was checked by fs@opera.com to run a CQ dry run

[commit-bot: I haz the power, 2017-06-03 17:19:10]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-03 18:55:02]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-03 18:55:03]

Dry run: Try jobs failed on following builders:
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[fs, 2017-06-03 19:45:24]

fs@opera.com changed reviewers:
+ pdr@chromium.org

[pdr., 2017-06-04 17:05:08]

LGTM, much tidier!

https://codereview.chromium.org/2920103002/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/svg/properties/SVGListPropertyHelper.h
(right):

https://codereview.chromium.org/2920103002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/svg/properties/SVGListPropertyHelper.h:231: //
TODO(fs): This should not cause us to throw an exception.
Is this actually deadcode due to the CheckIndexBound check?

[fs, 2017-06-04 17:11:27]

https://codereview.chromium.org/2920103002/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/svg/properties/SVGListPropertyHelper.h
(right):

https://codereview.chromium.org/2920103002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/svg/properties/SVGListPropertyHelper.h:231: //
TODO(fs): This should not cause us to throw an exception.
On 2017/06/04 at 17:05:08, pdr. wrote:
> Is this actually deadcode due to the CheckIndexBound check?

Yes, it certainly looks that way. Should check that we have test coverage for
this though (before removing.)

[fs, 2017-06-04 18:35:49]

The CQ bit was checked by fs@opera.com

[commit-bot: I haz the power, 2017-06-04 18:35:51]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-04 20:41:45]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1496601349686380, "parent_rev":
"5d7f817df99b9d87ef1f4d65529b2bba958a5713", "commit_rev":
"5f488b372798d523f0b6b48f6eec7efa6bf53500"}

[commit-bot: I haz the power, 2017-06-04 20:41:53]

Description was changed from

==========
Tidy up SVGListPropertyHelper

Turn some iterations into range-based for-loops. Use operator== from
Vector<...> rather than re-implementing it. Remove FindItem (unused.)
Deduplicate some code, replace 0 with nullptr where appropriate and
simplify the padding loop.

BUG=709001
==========

to

==========
Tidy up SVGListPropertyHelper

Turn some iterations into range-based for-loops. Use operator== from
Vector<...> rather than re-implementing it. Remove FindItem (unused.)
Deduplicate some code, replace 0 with nullptr where appropriate and
simplify the padding loop.

BUG=709001

Review-Url: https://codereview.chromium.org/2920103002
Cr-Commit-Position: refs/heads/master@{#476914}
Committed:
https://chromium.googlesource.com/chromium/src/+/5f488b372798d523f0b6b48f6eec...
==========

[commit-bot: I haz the power, 2017-06-04 20:41:54]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/5f488b372798d523f0b6b48f6eec...