Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2920093002:
[css-typed-om] use DOMMatrix::Create() instead of fromMatrix(). (Closed)
|
Created:
3 years, 6 months ago by Hwanseung Lee Modified:
3 years, 6 months ago Reviewers:
meade_UTC10 CC:
chromium-reviews, blink-reviews-css, dglazkov+blink, apavlov+blink_chromium.org, darktears, blink-reviews, rwlbuis Target Ref:
refs/heads/master Project:
chromium Visibility:
Public. |
Description[css-typed-om] use DOMMatrix::Create() instead of fromMatrix().
replace DOMMatrix::fromMatrix() with DOMMatrix::Create().
DOMMatrix::Create() can replaceable instead of DOMMatrix::fromMatrix()
which takes DOMMatrixInit as parameter.
DOMMatrix::fromMatrix() which takes DOMMatrixInit as parameter
have unnecessary copy.
BUG=545318
Review-Url: https://codereview.chromium.org/2920093002
Cr-Commit-Position: refs/heads/master@{#476966}
Committed: https://chromium.googlesource.com/chromium/src/+/af0818bdbbc28730cf1171e169eff4117dee86e3
Patch Set 1 #
Messages
Total messages: 18 (14 generated)
The CQ bit was checked by hs1217.lee@samsung.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)
The CQ bit was checked by hs1217.lee@samsung.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
Description was changed from ========== [css-typed-om] replace fromMatrix() with Create(). BUG= ========== to ========== [css-typed-om] use DOMMatrix::Create() instead of fromMatrix(). replace DOMMatrix::fromMatrix() with DOMMatrix::Create(). DOMMatrix::Create() can replaceable instead of DOMMatrix::fromMatrix() which takes DOMMatrixInit as parameter. DOMMatrix::fromMatrix() which takes DOMMatrixInit as parameter have unnecessary copy. BUG=None ==========
Description was changed from ========== [css-typed-om] use DOMMatrix::Create() instead of fromMatrix(). replace DOMMatrix::fromMatrix() with DOMMatrix::Create(). DOMMatrix::Create() can replaceable instead of DOMMatrix::fromMatrix() which takes DOMMatrixInit as parameter. DOMMatrix::fromMatrix() which takes DOMMatrixInit as parameter have unnecessary copy. BUG=None ========== to ========== [css-typed-om] use DOMMatrix::Create() instead of fromMatrix(). replace DOMMatrix::fromMatrix() with DOMMatrix::Create(). DOMMatrix::Create() can replaceable instead of DOMMatrix::fromMatrix() which takes DOMMatrixInit as parameter. DOMMatrix::fromMatrix() which takes DOMMatrixInit as parameter have unnecessary copy. BUG=545318 ==========
hs1217.lee@samsung.com changed reviewers: + meade@chromium.org
@meade PTAL, thank you.
lgtm
The CQ bit was checked by hs1217.lee@samsung.com
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 1, "attempt_start_ts": 1496644296130550, "parent_rev":
"d2142e047030add3194f190218a149dfc7983275", "commit_rev":
"af0818bdbbc28730cf1171e169eff4117dee86e3"}
Message was sent while issue was closed.
Description was changed from ========== [css-typed-om] use DOMMatrix::Create() instead of fromMatrix(). replace DOMMatrix::fromMatrix() with DOMMatrix::Create(). DOMMatrix::Create() can replaceable instead of DOMMatrix::fromMatrix() which takes DOMMatrixInit as parameter. DOMMatrix::fromMatrix() which takes DOMMatrixInit as parameter have unnecessary copy. BUG=545318 ========== to ========== [css-typed-om] use DOMMatrix::Create() instead of fromMatrix(). replace DOMMatrix::fromMatrix() with DOMMatrix::Create(). DOMMatrix::Create() can replaceable instead of DOMMatrix::fromMatrix() which takes DOMMatrixInit as parameter. DOMMatrix::fromMatrix() which takes DOMMatrixInit as parameter have unnecessary copy. BUG=545318 Review-Url: https://codereview.chromium.org/2920093002 Cr-Commit-Position: refs/heads/master@{#476966} Committed: https://chromium.googlesource.com/chromium/src/+/af0818bdbbc28730cf1171e169ef... ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/af0818bdbbc28730cf1171e169ef... |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
