Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1432)

Unified Diff: content/renderer/media/media_stream_constraints_util_video_content_unittest.cc

Issue 2919973003: Revert of Change default minimum screencast frame rate to zero. (Closed)
Patch Set: Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/renderer/media/media_stream_constraints_util_video_content.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/renderer/media/media_stream_constraints_util_video_content_unittest.cc
diff --git a/content/renderer/media/media_stream_constraints_util_video_content_unittest.cc b/content/renderer/media/media_stream_constraints_util_video_content_unittest.cc
index c31bef3d89af2af4ffa1959e8c86f1ac777e20cb..ae8ac1e670d31b00c5ad844e8621ab7fcbb6ef28 100644
--- a/content/renderer/media/media_stream_constraints_util_video_content_unittest.cc
+++ b/content/renderer/media/media_stream_constraints_util_video_content_unittest.cc
@@ -21,7 +21,6 @@
EXPECT_EQ(kDefaultScreenCastFrameRate, result.FrameRate());
EXPECT_EQ(base::Optional<bool>(), result.noise_reduction());
EXPECT_EQ(std::string(), result.device_id());
- EXPECT_EQ(0.0, result.min_frame_rate());
}
void CheckNonFrameRateDefaults(const VideoCaptureSettings& result) {
@@ -167,7 +166,7 @@
result.failed_constraint_name());
constraint_factory_.Reset();
- constraint_factory_.basic().frame_rate.SetMax(-0.1);
+ constraint_factory_.basic().frame_rate.SetMax(kMinScreenCastFrameRate - 0.1);
result = SelectSettings();
EXPECT_FALSE(result.HasValue());
EXPECT_EQ(constraint_factory_.basic().frame_rate.GetName(),
« no previous file with comments | « content/renderer/media/media_stream_constraints_util_video_content.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698