content/renderer/media/media_stream_constraints_util_video_content.cc - Issue 2919973003: Revert of Change default minimum screencast frame rate to zero.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/renderer/media/media_stream_constraints_util_video_content.cc

Issue 2919973003: Revert of Change default minimum screencast frame rate to zero. (Closed)

Patch Set: Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/renderer/media/media_stream_constraints_util_video_content.h ('k') | content/renderer/media/media_stream_constraints_util_video_content_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/renderer/media/media_stream_constraints_util_video_content.cc

diff --git a/content/renderer/media/media_stream_constraints_util_video_content.cc b/content/renderer/media/media_stream_constraints_util_video_content.cc

index d71fe79d603d0842e763161239400b46a0e81ec3..be48325e73af1be3f12c65bee0c3a3625467462c 100644

--- a/content/renderer/media/media_stream_constraints_util_video_content.cc

+++ b/content/renderer/media/media_stream_constraints_util_video_content.cc

@@ -35,6 +35,7 @@

static_assert(kDefaultScreenCastHeight <= kMaxScreenCastDimension,

"Invalid kDefaultScreenCastHeight");

+const double kMinScreenCastFrameRate = 1.0 / 60.0;

const double kMaxScreenCastFrameRate = 120.0;

const double kDefaultScreenCastFrameRate =

MediaStreamVideoSource::kDefaultFrameRate;

@@ -383,7 +384,7 @@

VideoContentCaptureCandidates candidates;

candidates.set_resolution_set(ScreenCastResolutionCapabilities());

candidates.set_frame_rate_set(

- DoubleRangeSet(0.0, kMaxScreenCastFrameRate));

+ DoubleRangeSet(kMinScreenCastFrameRate, kMaxScreenCastFrameRate));

// candidates.device_id_set and candidates.noise_reduction_set are

// automatically initialized with the universal set.