Update sandbox profiles and remove regular expressions.

Update sandbox profiles and remove regular expressions.

To simplify code cleanup and refactoring the V2 sandbox, remove the no
longer needed regular expressions from the current sandbox code. Sandbox
profiles now use (subpath) instead of the regular expressions.

BUG=689306
Review-Url: https://codereview.chromium.org/2919963003
Cr-Commit-Position: refs/heads/master@{#477020}
Committed: https://chromium.googlesource.com/chromium/src/+/a2e4f7f5c265cc867f21564d027afaf6a31550a9

[Greg K, 2017-06-02 17:29:11]

The CQ bit was checked by kerrnel@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-02 17:29:29]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Greg K, 2017-06-02 17:37:18]

The CQ bit was checked by kerrnel@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-02 17:37:30]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Greg K, 2017-06-02 17:37:49]

kerrnel@chromium.org changed reviewers:
+ rsesek@chromium.org

[Greg K, 2017-06-02 17:37:49]

PTAL.

Thanks,

Greg

[Robert Sesek, 2017-06-02 18:01:20]

Awesome! LGTM

[commit-bot: I haz the power, 2017-06-02 18:02:53]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-02 18:02:54]

Dry run: Try jobs failed on following builders:
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)

[Robert Sesek, 2017-06-02 18:04:44]

https://codereview.chromium.org/2919963003/diff/20001/content/common/sandbox_...
File content/common/sandbox_mac.h (left):

https://codereview.chromium.org/2919963003/diff/20001/content/common/sandbox_...
content/common/sandbox_mac.h:64: std::string* dst);
Though it looks like you need to remove the unittest for this too.

[Greg K, 2017-06-02 18:09:29]

The CQ bit was checked by kerrnel@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-02 18:10:10]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-02 18:26:30]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-02 18:26:31]

Dry run: Try jobs failed on following builders:
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[Greg K, 2017-06-02 21:22:59]

The CQ bit was checked by kerrnel@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-02 21:23:23]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-02 21:53:05]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-02 21:53:06]

Dry run: This issue passed the CQ dry run.

[Greg K, 2017-06-02 21:54:12]

On 2017/06/02 18:04:44, Robert Sesek wrote:
>
https://codereview.chromium.org/2919963003/diff/20001/content/common/sandbox_...
> File content/common/sandbox_mac.h (left):
> 
>
https://codereview.chromium.org/2919963003/diff/20001/content/common/sandbox_...
> content/common/sandbox_mac.h:64: std::string* dst);
> Though it looks like you need to remove the unittest for this too.

Cancelling out your previous LGTM:

Not LGTM

[Greg K, 2017-06-02 21:55:20]

On 2017/06/02 21:54:12, Greg K wrote:
> On 2017/06/02 18:04:44, Robert Sesek wrote:
> >
>
https://codereview.chromium.org/2919963003/diff/20001/content/common/sandbox_...
> > File content/common/sandbox_mac.h (left):
> > 
> >
>
https://codereview.chromium.org/2919963003/diff/20001/content/common/sandbox_...
> > content/common/sandbox_mac.h:64: std::string* dst);
> > Though it looks like you need to remove the unittest for this too.
> 
> Cancelling out your previous LGTM:
> 
> Not LGTM

Ok, please take a fresh look at this. I removed the string quoting entirely.
It's a bit confusing because it's not documented, but if you look at the
diraccess_unittest, all of the unicode characters work correctly without being
escaped into \uXXX. But with the escaping, the tests fail. I am confident then,
that the actual unicode can and should be passed into the parameters.

Thanks,

Greg

[Robert Sesek, 2017-06-05 16:53:09]

still lgtm

[Greg K, 2017-06-05 17:33:27]

The CQ bit was checked by kerrnel@chromium.org

[commit-bot: I haz the power, 2017-06-05 17:33:48]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-05 17:56:48]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1496684007232930,
"parent_rev": "d801058048b2af3c21e32efe9137561ead01e5ed", "commit_rev":
"a2e4f7f5c265cc867f21564d027afaf6a31550a9"}

[commit-bot: I haz the power, 2017-06-05 17:56:58]

Description was changed from

==========
Update sandbox profiles and remove regular expressions.

To simplify code cleanup and refactoring the V2 sandbox, remove the no
longer needed regular expressions from the current sandbox code. Sandbox
profiles now use (subpath) instead of the regular expressions.

BUG=689306
==========

to

==========
Update sandbox profiles and remove regular expressions.

To simplify code cleanup and refactoring the V2 sandbox, remove the no
longer needed regular expressions from the current sandbox code. Sandbox
profiles now use (subpath) instead of the regular expressions.

BUG=689306

Review-Url: https://codereview.chromium.org/2919963003
Cr-Commit-Position: refs/heads/master@{#477020}
Committed:
https://chromium.googlesource.com/chromium/src/+/a2e4f7f5c265cc867f21564d027a...
==========

[commit-bot: I haz the power, 2017-06-05 17:56:59]

Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/a2e4f7f5c265cc867f21564d027a...