Clean up issues raised on previous CL.

Clean up issues raised on previous CL.

Fixes issues raised in CL https://codereview.chromium.org/2887193002.
That is:

1) Remove using mutex in Isolate::InitializeCounters().

2) Use counters_shared_.get() instead of counters_ (and hence, also
   remove field counters_).

BUG=v8:6361
Review-Url: https://codereview.chromium.org/2919953003
Cr-Commit-Position: refs/heads/master@{#45743}
Committed: https://chromium.googlesource.com/v8/v8/+/9bc3bd4cddd29c048ea0762aa45dab57fd50bd0e

[kschimpf, 2017-06-02 17:06:47]

The CQ bit was checked by kschimpf@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-02 17:06:58]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[kschimpf, 2017-06-02 17:07:23]

Description was changed from

==========
Clean up issues raised on previous CL.

Fixes issues raised in CL https://codereview.chromium.org/2887193002.
That is:

1) Remove using mutex in Isolate::InitializeCounters().

2) Use counters_shared_.get() instead of counters_ (and hence, also
   remove field counters_).

BUG=v8:6361
==========

to

==========
Clean up issues raised on previous CL.

Fixes issues raised in CL https://codereview.chromium.org/2887193002.
That is:

1) Remove using mutex in Isolate::InitializeCounters().

2) Use counters_shared_.get() instead of counters_ (and hence, also
   remove field counters_).

BUG=v8:6361
==========

[kschimpf, 2017-06-02 17:07:23]

kschimpf@chromium.org changed reviewers:
+ clemensh@chromium.org, jochen@chromium.org, mtrofin@chromium.org

[commit-bot: I haz the power, 2017-06-02 17:37:48]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-02 17:37:49]

Dry run: This issue passed the CQ dry run.

[kschimpf, 2017-06-05 14:51:25]

Please review. Thanks!

[Mircea Trofin, 2017-06-05 15:35:11]

lgtm, 2 nits.

https://codereview.chromium.org/2919953003/diff/1/src/isolate.cc
File src/isolate.cc (right):

https://codereview.chromium.org/2919953003/diff/1/src/isolate.cc#newcode2859
src/isolate.cc:2859: return stats_table_ = counters_shared_->stats_table();
Nit: I know this is how it was before, but can you separate assignment and
return on different lines?

https://codereview.chromium.org/2919953003/diff/1/src/isolate.h
File src/isolate.h (right):

https://codereview.chromium.org/2919953003/diff/1/src/isolate.h#newcode873
src/isolate.h:873: DCHECK(counters_shared_.get() != NULL);
Nit: I realize this is existing code, but DCHECK_NOT_NULL

[kschimpf, 2017-06-05 18:05:43]

https://codereview.chromium.org/2919953003/diff/1/src/isolate.cc
File src/isolate.cc (right):

https://codereview.chromium.org/2919953003/diff/1/src/isolate.cc#newcode2859
src/isolate.cc:2859: return stats_table_ = counters_shared_->stats_table();
On 2017/06/05 15:35:11, Mircea Trofin wrote:
> Nit: I know this is how it was before, but can you separate assignment and
> return on different lines? 

Done.

https://codereview.chromium.org/2919953003/diff/1/src/isolate.h
File src/isolate.h (right):

https://codereview.chromium.org/2919953003/diff/1/src/isolate.h#newcode873
src/isolate.h:873: DCHECK(counters_shared_.get() != NULL);
On 2017/06/05 15:35:11, Mircea Trofin wrote:
> Nit: I realize this is existing code, but DCHECK_NOT_NULL

Done.

[kschimpf, 2017-06-05 18:05:48]

The CQ bit was checked by kschimpf@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-05 18:05:56]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-05 18:37:49]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-05 18:37:50]

Dry run: This issue passed the CQ dry run.

[Clemens Hammacher, 2017-06-06 07:29:52]

LGTM, thanks!

[jochen (gone - plz use gerrit), 2017-06-06 14:41:59]

I just checked that it doesn't touch histograms, so lgtm

[kschimpf, 2017-06-06 17:18:08]

The CQ bit was checked by kschimpf@chromium.org

[kschimpf, 2017-06-06 17:18:08]

The patchset sent to the CQ was uploaded after l-g-t-m from mtrofin@chromium.org
Link to the patchset: https://codereview.chromium.org/2919953003/#ps20001
(title: "Fix nits.")

[commit-bot: I haz the power, 2017-06-06 17:18:11]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-06 17:19:44]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1496769488396730,
"parent_rev": "579c1e2976efdae7416ce670b12c8a6365695f05", "commit_rev":
"9bc3bd4cddd29c048ea0762aa45dab57fd50bd0e"}

[commit-bot: I haz the power, 2017-06-06 17:19:50]

Description was changed from

==========
Clean up issues raised on previous CL.

Fixes issues raised in CL https://codereview.chromium.org/2887193002.
That is:

1) Remove using mutex in Isolate::InitializeCounters().

2) Use counters_shared_.get() instead of counters_ (and hence, also
   remove field counters_).

BUG=v8:6361
==========

to

==========
Clean up issues raised on previous CL.

Fixes issues raised in CL https://codereview.chromium.org/2887193002.
That is:

1) Remove using mutex in Isolate::InitializeCounters().

2) Use counters_shared_.get() instead of counters_ (and hence, also
   remove field counters_).

BUG=v8:6361

Review-Url: https://codereview.chromium.org/2919953003
Cr-Commit-Position: refs/heads/master@{#45743}
Committed:
https://chromium.googlesource.com/v8/v8/+/9bc3bd4cddd29c048ea0762aa45dab57fd5...
==========

[commit-bot: I haz the power, 2017-06-06 17:19:52]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/v8/v8/+/9bc3bd4cddd29c048ea0762aa45dab57fd5...