DescriptionRevert of Unpack theme data from extensions off of UI thread. (patchset #17 id:320001 of https://codereview.chromium.org/2799003002/ )
Reason for revert:
This causes ThemeServiceBrowserTest test failure on Linux:
https://uberchromegw.corp.google.com/i/chromium.memory/builders/Linux%20ChromiumOS%20MSan%20Tests/builds/893
Original issue's description:
> Unpack theme data from extensions off of UI thread.
>
> Even on a beefy workstation, resizing theme images takes a long time
> (>1s). This causes a painful hiccup in the UI. This patch addresses that
> by moving the operation to a helper thread. The actual application of
> the theme won't be any faster but it won't block interaction.
>
> As a future area of investigation it might be worth changing the "theme
> installed" infobar to show earlier with a message like "installing
> theme..." until this operation is completed, since otherwise it can feel
> like nothing is happening.
>
> BUG=316070
>
> Review-Url: https://codereview.chromium.org/2799003002
> Cr-Commit-Position: refs/heads/master@{#476505}
> Committed: https://chromium.googlesource.com/chromium/src/+/49c3b86554c09f298bd100c02c812be4aa2f0e15
TBR=pkotwicz@chromium.org,erg@chromium.org,pavely@chromium.org,rdevlin.cronin@chromium.org,pkasting@chromium.org,estade@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=316070
Review-Url: https://codereview.chromium.org/2919953002
Cr-Commit-Position: refs/heads/master@{#476567}
Committed: https://chromium.googlesource.com/chromium/src/+/1199a6c0e721df366b0076ba5c9af68e98c1cfbb
Patch Set 1 #Messages
Total messages: 6 (3 generated)
|