Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(320)

Issue 2919953002: Revert of Unpack theme data from extensions off of UI thread. (Closed)

Created:
3 years, 6 months ago by yoichio
Modified:
3 years, 6 months ago
CC:
chromium-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Unpack theme data from extensions off of UI thread. (patchset #17 id:320001 of https://codereview.chromium.org/2799003002/ ) Reason for revert: This causes ThemeServiceBrowserTest test failure on Linux: https://uberchromegw.corp.google.com/i/chromium.memory/builders/Linux%20ChromiumOS%20MSan%20Tests/builds/893 Original issue's description: > Unpack theme data from extensions off of UI thread. > > Even on a beefy workstation, resizing theme images takes a long time > (>1s). This causes a painful hiccup in the UI. This patch addresses that > by moving the operation to a helper thread. The actual application of > the theme won't be any faster but it won't block interaction. > > As a future area of investigation it might be worth changing the "theme > installed" infobar to show earlier with a message like "installing > theme..." until this operation is completed, since otherwise it can feel > like nothing is happening. > > BUG=316070 > > Review-Url: https://codereview.chromium.org/2799003002 > Cr-Commit-Position: refs/heads/master@{#476505} > Committed: https://chromium.googlesource.com/chromium/src/+/49c3b86554c09f298bd100c02c812be4aa2f0e15 TBR=pkotwicz@chromium.org,erg@chromium.org,pavely@chromium.org,rdevlin.cronin@chromium.org,pkasting@chromium.org,estade@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=316070 Review-Url: https://codereview.chromium.org/2919953002 Cr-Commit-Position: refs/heads/master@{#476567} Committed: https://chromium.googlesource.com/chromium/src/+/1199a6c0e721df366b0076ba5c9af68e98c1cfbb

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+214 lines, -361 lines) Patch
M chrome/browser/extensions/extension_install_ui_browsertest.cc View 7 chunks +6 lines, -35 lines 0 comments Download
M chrome/browser/extensions/extension_service_sync_unittest.cc View 3 chunks +0 lines, -8 lines 0 comments Download
M chrome/browser/extensions/theme_installed_infobar_delegate.cc View 1 chunk +1 line, -3 lines 0 comments Download
M chrome/browser/infobars/infobars_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/sync/test/integration/single_client_themes_sync_test.cc View 3 chunks +30 lines, -37 lines 0 comments Download
M chrome/browser/sync/test/integration/sync_integration_test_util.h View 1 chunk +0 lines, -5 lines 0 comments Download
M chrome/browser/sync/test/integration/sync_integration_test_util.cc View 1 chunk +0 lines, -13 lines 0 comments Download
M chrome/browser/sync/test/integration/two_client_themes_sync_test.cc View 5 chunks +7 lines, -7 lines 0 comments Download
M chrome/browser/themes/browser_theme_pack.h View 7 chunks +16 lines, -21 lines 0 comments Download
M chrome/browser/themes/browser_theme_pack.cc View 9 chunks +30 lines, -25 lines 0 comments Download
M chrome/browser/themes/browser_theme_pack_unittest.cc View 6 chunks +30 lines, -43 lines 0 comments Download
M chrome/browser/themes/theme_service.h View 5 chunks +2 lines, -26 lines 0 comments Download
M chrome/browser/themes/theme_service.cc View 12 chunks +47 lines, -94 lines 0 comments Download
M chrome/browser/themes/theme_service_browsertest.cc View 3 chunks +0 lines, -10 lines 0 comments Download
M chrome/browser/themes/theme_service_unittest.cc View 6 chunks +15 lines, -24 lines 0 comments Download
M chrome/browser/ui/extensions/extension_install_ui_default.h View 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/browser/ui/extensions/extension_install_ui_default.cc View 2 chunks +21 lines, -2 lines 0 comments Download
M chrome/browser/ui/search/instant_extended_interactive_uitest.cc View 2 chunks +4 lines, -7 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
yoichio
Created Revert of Unpack theme data from extensions off of UI thread.
3 years, 6 months ago (2017-06-02 04:37:06 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2919953002/1
3 years, 6 months ago (2017-06-02 04:37:26 UTC) #3
commit-bot: I haz the power
3 years, 6 months ago (2017-06-02 04:38:01 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/1199a6c0e721df366b0076ba5c9a...

Powered by Google App Engine
This is Rietveld 408576698