Chromium Code Reviews
DescriptionAvoid treating the load of about:blank as a failure in the web auth flow.
As part of the OAUth 2.0 protocol with GAIA, at the end of the web
authorization flow, GAIA redirects to a custom scheme URL of type
|com.googleusercontent.apps.123:/<extension_id>|, where
|com.googleusercontent.apps.123| is the reverse DNS notation of the
client ID.
It look like this URL is not an web accessible URL from within a Guest WebView, so
during the load of this URL, Chrome validates and changes it to "about:blank",
which then fails to be loaded within the context of the Identity Scope Approval
Dialog extension. Note that in fact, it is better to avoid the load of |about:blank|
as the dialog will actually be closed right after this load fails.
This CL avoids treating the failure of loading |about:blank| as a failure
of the web auth flow.
BUG=722323
Review-Url: https://codereview.chromium.org/2901283002
Cr-Original-Commit-Position: refs/heads/master@{#475894}
Review-Url: https://codereview.chromium.org/2919943003 .
Cr-Commit-Position: refs/branch-heads/3112@{#116}
Cr-Branched-From: b6460e24cf59f429d69de255538d0fc7a425ccf9-refs/heads/master@{#474897}
Committed: https://chromium.googlesource.com/chromium/src/+/443ffe5729635a7e0e2313278393443c7611af66
Patch Set 1 #
Messages
Total messages: 2 (1 generated)
|
|||||||||||||||||||