Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1140)

Issue 2919943002: [CSS Typed OM] Rename CSSUnitValue's cssType method to just "type". (Closed)

Created:
3 years, 6 months ago by meade_UTC10
Modified:
3 years, 6 months ago
Reviewers:
nainar, shend
CC:
nainar, darktears, apavlov+blink_chromium.org, blink-reviews, blink-reviews-css, chromium-reviews, dglazkov+blink, rwlbuis
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

[CSS Typed OM] Rename CSSUnitValue's cssType method to just "type". There's no particular reason why it was different. No test changes as the JS-exposed interface doesn't change. Review-Url: https://codereview.chromium.org/2919943002 Cr-Commit-Position: refs/heads/master@{#476593} Committed: https://chromium.googlesource.com/chromium/src/+/05381409884cc4b9b1e15eeeff4dc624088b9ab3

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M third_party/WebKit/Source/core/css/cssom/CSSUnitValue.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/css/cssom/CSSUnitValue.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/css/cssom/CSSUnitValue.idl View 1 chunk +1 line, -1 line 0 comments Download

Dependent Patchsets:

Messages

Total messages: 14 (9 generated)
meade_UTC10
Hey Darren, PTAL! nainar: FYI since you requested it be split out of my other ...
3 years, 6 months ago (2017-06-02 04:25:59 UTC) #2
shend
lgtm
3 years, 6 months ago (2017-06-02 04:29:48 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2919943002/1
3 years, 6 months ago (2017-06-02 04:38:44 UTC) #9
nainar
lgtm
3 years, 6 months ago (2017-06-02 04:50:25 UTC) #11
commit-bot: I haz the power
3 years, 6 months ago (2017-06-02 06:34:15 UTC) #14
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/05381409884cc4b9b1e15eeeff4d...

Powered by Google App Engine
This is Rietveld 408576698