Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(71)

Issue 2919933002: Revert of ChromeOS: Per-user time zone: refactor tests first. (Closed)

Created:
3 years, 6 months ago by Peter Kasting
Modified:
3 years, 6 months ago
CC:
chromium-reviews, dbeam+watch-options_chromium.org, extensions-reviews_chromium.org, msramek+watch_chromium.org, alemate+watch_chromium.org, Peter Beverloo, awdf+watch_chromium.org, Lei Zhang, yamaguchi+watch_chromium.org, oka+watch_chromium.org, achuith+watch_chromium.org, tommycli, rginda+watch_chromium.org, michaelpg+watch-options_chromium.org, oshima+watch_chromium.org, fukino+watch_chromium.org, chromium-apps-reviews_chromium.org, markusheintz_, mlamouri+watch-notifications_chromium.org, davemoore+watch_chromium.org, Bernhard Bauer, Devlin, Reilly Grant (use Gerrit)
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of ChromeOS: Per-user time zone: refactor tests first. (patchset #10 id:180001 of https://codereview.chromium.org/2907493002/ ) Reason for revert: Looks to have caused Linux CrOS link failure: https://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromiumOS%20Builder%20%28dbg%29/builds/87898 Original issue's description: > ChromeOS: Per-user time zone: refactor tests first. > > This Cl prepares tests to support per-user timezone implementation. > > BUG=622555, 699472 > > TBR=bauerb@chromium.org,rdevlin.cronin@chromium.org,reillyg@chromium.org > > Review-Url: https://codereview.chromium.org/2907493002 > Cr-Commit-Position: refs/heads/master@{#476478} > Committed: https://chromium.googlesource.com/chromium/src/+/410dbeb8df3d4ab140390d7d1e603163885c8c9c TBR=stevenjb@chromium.org,phajdan.jr@chromium.org,xiyuan@chromium.org,alemate@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=622555, 699472 Review-Url: https://codereview.chromium.org/2919933002 Cr-Commit-Position: refs/heads/master@{#476496} Committed: https://chromium.googlesource.com/chromium/src/+/a4b98df10877a69266bcddca89cd042ba8191748

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+208 lines, -195 lines) Patch
M chrome/browser/browsing_data/chrome_browsing_data_remover_delegate_unittest.cc View 2 chunks +4 lines, -0 lines 0 comments Download
M chrome/browser/chromeos/BUILD.gn View 2 chunks +0 lines, -3 lines 0 comments Download
M chrome/browser/chromeos/customization/customization_document_unittest.cc View 2 chunks +0 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/extensions/active_tab_permission_granter_delegate_chromeos_unittest.cc View 2 chunks +1 line, -4 lines 0 comments Download
M chrome/browser/chromeos/extensions/public_session_permission_helper_unittest.cc View 2 chunks +1 line, -3 lines 0 comments Download
M chrome/browser/chromeos/file_manager/path_util_unittest.cc View 2 chunks +0 lines, -10 lines 0 comments Download
M chrome/browser/chromeos/login/auth/cryptohome_authenticator_unittest.cc View 2 chunks +5 lines, -10 lines 0 comments Download
M chrome/browser/chromeos/login/hwid_checker_unittest.cc View 8 chunks +16 lines, -11 lines 0 comments Download
M chrome/browser/chromeos/login/signin/merge_session_load_page_unittest.cc View 3 chunks +14 lines, -0 lines 0 comments Download
M chrome/browser/chromeos/login/users/chrome_user_manager_impl.cc View 2 chunks +2 lines, -7 lines 0 comments Download
M chrome/browser/chromeos/login/users/supervised_user_manager_impl.cc View 1 chunk +1 line, -3 lines 0 comments Download
M chrome/browser/chromeos/policy/device_cloud_policy_store_chromeos.cc View 2 chunks +1 line, -3 lines 0 comments Download
D chrome/browser/chromeos/scoped_set_running_on_chromeos_for_testing.h View 1 chunk +0 lines, -31 lines 0 comments Download
D chrome/browser/chromeos/scoped_set_running_on_chromeos_for_testing.cc View 1 chunk +0 lines, -21 lines 0 comments Download
M chrome/browser/extensions/active_tab_unittest.cc View 3 chunks +5 lines, -1 line 0 comments Download
M chrome/browser/extensions/activity_log/activity_database_unittest.cc View 3 chunks +20 lines, -0 lines 0 comments Download
M chrome/browser/extensions/activity_log/activity_log_enabled_unittest.cc View 2 chunks +18 lines, -0 lines 0 comments Download
M chrome/browser/extensions/activity_log/activity_log_unittest.cc View 4 chunks +18 lines, -0 lines 0 comments Download
M chrome/browser/extensions/api/image_writer_private/operation_manager_unittest.cc View 2 chunks +12 lines, -0 lines 0 comments Download
M chrome/browser/extensions/extension_service_unittest.cc View 3 chunks +15 lines, -0 lines 0 comments Download
M chrome/browser/extensions/test_extension_system.h View 2 chunks +0 lines, -8 lines 0 comments Download
M chrome/browser/extensions/test_extension_system.cc View 2 chunks +1 line, -9 lines 0 comments Download
M chrome/browser/media_galleries/media_file_system_registry_unittest.cc View 4 chunks +10 lines, -0 lines 0 comments Download
M chrome/browser/notifications/extension_welcome_notification_unittest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/notifications/platform_notification_service_unittest.cc View 2 chunks +13 lines, -0 lines 0 comments Download
M chrome/test/BUILD.gn View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/test/base/testing_profile.h View 2 chunks +0 lines, -9 lines 0 comments Download
M chrome/test/base/testing_profile.cc View 2 chunks +0 lines, -8 lines 0 comments Download
M components/user_manager/user_manager_base.cc View 20 chunks +49 lines, -49 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
Peter Kasting
Created Revert of ChromeOS: Per-user time zone: refactor tests first.
3 years, 6 months ago (2017-06-02 00:23:58 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2919933002/1
3 years, 6 months ago (2017-06-02 00:24:40 UTC) #3
commit-bot: I haz the power
3 years, 6 months ago (2017-06-02 00:27:32 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/a4b98df10877a69266bcddca89cd...

Powered by Google App Engine
This is Rietveld 408576698