Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(367)

Issue 291993003: base atomicops: Drop SSE2 detection, we always require SSE2 starting in m35. (Closed)

Created:
6 years, 7 months ago by Nico
Modified:
6 years, 7 months ago
Reviewers:
Mark Mentovai
CC:
chromium-reviews, erikwright+watch_chromium.org
Visibility:
Public.

Description

base atomicops: Drop SSE2 detection, we always require SSE2 starting in m35. BUG=348761, 94925 NOTRY=true Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=271506

Patch Set 1 #

Total comments: 2

Patch Set 2 : tweak #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -31 lines) Patch
M base/atomicops_internals_x86_gcc.h View 1 3 chunks +0 lines, -27 lines 0 comments Download
M base/atomicops_internals_x86_gcc.cc View 2 chunks +0 lines, -4 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
Nico
6 years, 7 months ago (2014-05-19 21:56:41 UTC) #1
Mark Mentovai
LGTM https://codereview.chromium.org/291993003/diff/1/base/atomicops_internals_x86_gcc.h File base/atomicops_internals_x86_gcc.h (right): https://codereview.chromium.org/291993003/diff/1/base/atomicops_internals_x86_gcc.h#newcode94 base/atomicops_internals_x86_gcc.h:94: // 64-bit implementations of memory barrier can be ...
6 years, 7 months ago (2014-05-19 22:24:34 UTC) #2
Nico
Thanks! https://codereview.chromium.org/291993003/diff/1/base/atomicops_internals_x86_gcc.h File base/atomicops_internals_x86_gcc.h (right): https://codereview.chromium.org/291993003/diff/1/base/atomicops_internals_x86_gcc.h#newcode94 base/atomicops_internals_x86_gcc.h:94: // 64-bit implementations of memory barrier can be ...
6 years, 7 months ago (2014-05-19 22:29:10 UTC) #3
Nico
The CQ bit was checked by thakis@chromium.org
6 years, 7 months ago (2014-05-19 22:29:34 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/thakis@chromium.org/291993003/20001
6 years, 7 months ago (2014-05-19 22:30:41 UTC) #5
commit-bot: I haz the power
6 years, 7 months ago (2014-05-19 22:37:24 UTC) #6
Message was sent while issue was closed.
Change committed as 271506

Powered by Google App Engine
This is Rietveld 408576698