Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(621)

Issue 2919913002: Add SpellCheckTestBase::GetSpellChecker() (Closed)

Created:
3 years, 6 months ago by Xiaocheng
Modified:
3 years, 6 months ago
Reviewers:
yosin_UTC9
CC:
blink-reviews, chromium-reviews, groby+blinkspell_chromium.org, timvolodine, Xiaocheng
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Add SpellCheckTestBase::GetSpellChecker() This patch adds a getter of the SpellChecker of the current frame for unit test, so that unit tests can be made simpler. BUG=n/a TEST=n/a; no behavioral change Review-Url: https://codereview.chromium.org/2919913002 Cr-Commit-Position: refs/heads/master@{#476566} Committed: https://chromium.googlesource.com/chromium/src/+/1585a345307652341504b55886d00434fdf3fe39

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -7 lines) Patch
M third_party/WebKit/Source/core/editing/spellcheck/IdleSpellCheckCallbackTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/editing/spellcheck/SpellCheckTestBase.h View 1 chunk +4 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/editing/spellcheck/SpellCheckTestBase.cpp View 2 chunks +6 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/editing/spellcheck/SpellCheckerTest.cpp View 4 chunks +5 lines, -6 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 15 (10 generated)
Xiaocheng
PTAL.
3 years, 6 months ago (2017-06-02 01:49:58 UTC) #4
yosin_UTC9
lgtm
3 years, 6 months ago (2017-06-02 02:13:30 UTC) #7
commit-bot: I haz the power
This CL has an open dependency (Issue 2919883002 Patch 1). Please resolve the dependency and ...
3 years, 6 months ago (2017-06-02 02:13:39 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2919913002/1
3 years, 6 months ago (2017-06-02 04:29:53 UTC) #11
commit-bot: I haz the power
3 years, 6 months ago (2017-06-02 04:34:14 UTC) #15
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/1585a345307652341504b55886d0...

Powered by Google App Engine
This is Rietveld 408576698