Add flag to signal that video frame must be drawn using an overlay.

Add flag to signal that video frame must be drawn using an overlay.

Some textures must be put into overlays, so add a flag to YUVVideoDrawQuad
to signal that to the renderer.

BUG=729238
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel

Review-Url: https://codereview.chromium.org/2919863004
Cr-Commit-Position: refs/heads/master@{#479155}
Committed: https://chromium.googlesource.com/chromium/src/+/6abe558714692485d29e724beea91d641f98bdb7

[jbauman, 2017-06-02 23:37:40]

Description was changed from

==========
Add flag to signal that video frame must be drawn using an overlay.

BUG=729328
==========

to

==========
Add flag to signal that video frame must be drawn using an overlay.

BUG=729328
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
==========

[jbauman, 2017-06-02 23:37:49]

The CQ bit was checked by jbauman@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-02 23:38:50]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-02 23:59:23]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-02 23:59:24]

Dry run: Try jobs failed on following builders:
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[jbauman, 2017-06-03 01:20:19]

The CQ bit was checked by jbauman@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-03 01:20:48]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-03 03:10:59]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-03 03:10:59]

Dry run: This issue passed the CQ dry run.

[jbauman, 2017-06-06 23:37:41]

Description was changed from

==========
Add flag to signal that video frame must be drawn using an overlay.

BUG=729328
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
==========

to

==========
Add flag to signal that video frame must be drawn using an overlay.

Some textures must be put into overlays, so add a flag to YUVVideoDrawQuad
to signal that to the renderer.

BUG=729238
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
==========

[jbauman, 2017-06-06 23:37:48]

jbauman@chromium.org changed reviewers:
+ danakj@chromium.org

[jbauman, 2017-06-06 23:44:26]

jbauman@chromium.org changed reviewers:
+ sandersd@chromium.org

[danakj, 2017-06-07 15:26:40]

LGTM

https://codereview.chromium.org/2919863004/diff/20001/cc/ipc/cc_param_traits_...
File cc/ipc/cc_param_traits_unittest.cc (right):

https://codereview.chromium.org/2919863004/diff/20001/cc/ipc/cc_param_traits_...
cc/ipc/cc_param_traits_unittest.cc:208: EXPECT_EQ(a->bits_per_channel,
b->bits_per_channel);
Compare it here?

https://codereview.chromium.org/2919863004/diff/20001/cc/quads/draw_quad_unit...
File cc/quads/draw_quad_unittest.cc (right):

https://codereview.chromium.org/2919863004/diff/20001/cc/quads/draw_quad_unit...
cc/quads/draw_quad_unittest.cc:128: #define CREATE_QUAD_ALL(Type, ...)          
                             \
Oh cute, can you remove all the CREATE_QUAD_X_ALL and use this?

https://codereview.chromium.org/2919863004/diff/20001/media/base/video_frame_...
File media/base/video_frame_metadata.h (right):

https://codereview.chromium.org/2919863004/diff/20001/media/base/video_frame_...
media/base/video_frame_metadata.h:118: // rahter than with the GLRenderer.
typo: rather

maybe instead of naming the GLRenderer here, "rather than being composited into
the framebuffer" ?

[jbauman, 2017-06-07 21:06:39]

The CQ bit was checked by jbauman@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-07 21:08:02]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-07 21:09:29]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-07 21:09:30]

Dry run: CQ cannot get SignCLA result. Please try later.

[sandersd (OOO until July 31), 2017-06-13 18:33:36]

media/ lgtm.

https://codereview.chromium.org/2919863004/diff/40001/media/base/video_frame_...
File media/base/video_frame_metadata.h (right):

https://codereview.chromium.org/2919863004/diff/40001/media/base/video_frame_...
media/base/video_frame_metadata.h:117: // Windows only: if set, then this frame
must be displayed in an overlay
FYI: Android has this same situation; frames released to a SurfaceView cannot be
retroactively composited. This hasn't been a huge problem, because we have
written the Android overlay processor to be aware of that. We should probably be
setting this key on Android too, though.

The two keys above (SURFACE_TEXTURE and WANTS_PROMOTION_HINT) are part of the
infrastructure we are building to be able to switch overlay modes in more cases
(that is, other than fullscreen toggle), with the understanding that some frames
may be lost at overlay->composited transitions.

[jbauman, 2017-06-13 18:39:48]

The CQ bit was checked by jbauman@chromium.org

[jbauman, 2017-06-13 18:39:48]

The patchset sent to the CQ was uploaded after l-g-t-m from danakj@chromium.org
Link to the patchset: https://codereview.chromium.org/2919863004/#ps40001
(title: "cleanup")

[commit-bot: I haz the power, 2017-06-13 18:40:16]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-13 18:51:47]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-13 18:51:48]

Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[jbauman, 2017-06-13 20:52:54]

jbauman@chromium.org changed reviewers:
+ kenrb@chromium.org

[jbauman, 2017-06-13 20:52:55]

kenrb@: security review

[kenrb, 2017-06-13 21:12:32]

mojom lgtm

[jbauman, 2017-06-13 21:14:48]

The CQ bit was checked by jbauman@chromium.org

[commit-bot: I haz the power, 2017-06-13 21:15:15]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-13 21:22:20]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1497388488178380,
"parent_rev": "b68e3bed1ed8f2b84cbc53c8ce9a3dc7a2536858", "commit_rev":
"6abe558714692485d29e724beea91d641f98bdb7"}

[commit-bot: I haz the power, 2017-06-13 21:22:34]

Description was changed from

==========
Add flag to signal that video frame must be drawn using an overlay.

Some textures must be put into overlays, so add a flag to YUVVideoDrawQuad
to signal that to the renderer.

BUG=729238
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
==========

to

==========
Add flag to signal that video frame must be drawn using an overlay.

Some textures must be put into overlays, so add a flag to YUVVideoDrawQuad
to signal that to the renderer.

BUG=729238
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel

Review-Url: https://codereview.chromium.org/2919863004
Cr-Commit-Position: refs/heads/master@{#479155}
Committed:
https://chromium.googlesource.com/chromium/src/+/6abe558714692485d29e724beea9...
==========

[commit-bot: I haz the power, 2017-06-13 21:22:36]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/6abe558714692485d29e724beea9...