Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(231)

Issue 2919863003: Fix a reachable LOG(ERROR) from path builder unit-test. (Closed)

Created:
3 years, 6 months ago by eroman
Modified:
3 years, 6 months ago
Reviewers:
mattm
CC:
chromium-reviews, cbentzel+watch_chromium.org, net-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix a reachable LOG(ERROR) from path builder unit-test. This line was reachable from the test: target-and-intermediate/unspecified-trust-root.test The result of the test hasn't changed (path building still fails), however now path building will be able to retrieve the root certificate from the trust store when using it as a CertIssuerSource. Review-Url: https://codereview.chromium.org/2919863003 Cr-Commit-Position: refs/heads/master@{#476762} Committed: https://chromium.googlesource.com/chromium/src/+/e43cd34d7b6f8ce4a48f4e3a704c01e3c6e25dfc

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -1 line) Patch
M net/cert/internal/path_builder_verify_certificate_chain_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/cert/internal/trust_store_in_memory.h View 1 chunk +4 lines, -0 lines 0 comments Download
M net/cert/internal/trust_store_in_memory.cc View 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (8 generated)
eroman
3 years, 6 months ago (2017-06-02 01:20:54 UTC) #3
mattm
lgtm
3 years, 6 months ago (2017-06-02 02:22:44 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2919863003/1
3 years, 6 months ago (2017-06-02 19:44:33 UTC) #9
commit-bot: I haz the power
3 years, 6 months ago (2017-06-02 19:50:10 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/e43cd34d7b6f8ce4a48f4e3a704c...

Powered by Google App Engine
This is Rietveld 408576698