Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(38)

Issue 2919713002: Update operator<<(SelectionState) (Closed)

Created:
3 years, 6 months ago by yoichio
Modified:
3 years, 6 months ago
Reviewers:
kojii, yosin_UTC9
CC:
blink-reviews, blink-reviews-layout_chromium.org, chromium-reviews, eae+blinkwatch, jchaffraix+rendering, leviw+renderwatch, pdr+renderingwatchlist_chromium.org, szager+layoutwatch_chromium.org, zoltan1
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Update operator<<(SelectionState) This CL changes the operator returning appropriate string. This is homework from: [Make SelectionState enum class] https://codereview.chromium.org/2916493002/ BUG= Review-Url: https://codereview.chromium.org/2919713002 Cr-Commit-Position: refs/heads/master@{#476229} Committed: https://chromium.googlesource.com/chromium/src/+/4a0488068b1b5af0a38e5b05a771ab81a53e417a

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M third_party/WebKit/Source/core/layout/api/SelectionState.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/layout/api/SelectionStateTest.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 17 (10 generated)
yoichio
3 years, 6 months ago (2017-06-01 05:08:28 UTC) #5
yosin_UTC9
lgtm
3 years, 6 months ago (2017-06-01 05:39:24 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2919713002/1
3 years, 6 months ago (2017-06-01 05:39:34 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/452970)
3 years, 6 months ago (2017-06-01 05:46:32 UTC) #11
kojii
lgtm
3 years, 6 months ago (2017-06-01 07:43:10 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2919713002/1
3 years, 6 months ago (2017-06-01 07:43:32 UTC) #14
commit-bot: I haz the power
3 years, 6 months ago (2017-06-01 08:50:01 UTC) #17
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/4a0488068b1b5af0a38e5b05a771...

Powered by Google App Engine
This is Rietveld 408576698