third_party/WebKit/Source/platform/wtf/ThreadSpecificWin.cpp - Issue 2919653004: Use LOG() or LOG_IF() instead of IMMEDIATE_CRASH

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/wtf/ThreadSpecificWin.cpp

Issue 2919653004: Use LOG() or LOG_IF() instead of IMMEDIATE_CRASH (Closed)

Patch Set: Use LOG() or CHECK()|CHECK_FOO() instead of IMMEDIATE_CRASH Created 3 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/platform/wtf/ThreadSpecificWin.cpp

diff --git a/third_party/WebKit/Source/platform/wtf/ThreadSpecificWin.cpp b/third_party/WebKit/Source/platform/wtf/ThreadSpecificWin.cpp

index b54917ece1be9c1dcf122c2d430ebccb7887b546..5f128966ace6045d736b8caaca26af43eaf9e901 100644

--- a/third_party/WebKit/Source/platform/wtf/ThreadSpecificWin.cpp

+++ b/third_party/WebKit/Source/platform/wtf/ThreadSpecificWin.cpp

@@ -52,8 +52,7 @@ class PlatformThreadSpecificKey

PlatformThreadSpecificKey(void (*destructor)(void*))

: destructor_(destructor) {

tls_key_ = TlsAlloc();

- if (tls_key_ == TLS_OUT_OF_INDEXES)

- IMMEDIATE_CRASH();

+ CHECK_NE(tls_key_, TLS_OUT_OF_INDEXES);

}

~PlatformThreadSpecificKey() { TlsFree(tls_key_); }