Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1788)

Unified Diff: third_party/WebKit/Source/platform/wtf/ThreadSpecific.h

Issue 2919653004: Use LOG() or LOG_IF() instead of IMMEDIATE_CRASH (Closed)
Patch Set: Use LOG() or CHECK()|CHECK_FOO() instead of IMMEDIATE_CRASH Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/platform/wtf/ThreadSpecific.h
diff --git a/third_party/WebKit/Source/platform/wtf/ThreadSpecific.h b/third_party/WebKit/Source/platform/wtf/ThreadSpecific.h
index f1582d949f45a82113f963a4875651084fefbb86..cad2797d6cc7c41e8f97be73b4a040bf60dabb58 100644
--- a/third_party/WebKit/Source/platform/wtf/ThreadSpecific.h
+++ b/third_party/WebKit/Source/platform/wtf/ThreadSpecific.h
@@ -125,14 +125,12 @@ typedef pthread_key_t ThreadSpecificKey;
inline void ThreadSpecificKeyCreate(ThreadSpecificKey* key,
void (*destructor)(void*)) {
int error = pthread_key_create(key, destructor);
- if (error)
- IMMEDIATE_CRASH();
+ CHECK(!error);
}
inline void ThreadSpecificKeyDelete(ThreadSpecificKey key) {
int error = pthread_key_delete(key);
- if (error)
- IMMEDIATE_CRASH();
+ CHECK(!error);
}
inline void ThreadSpecificSet(ThreadSpecificKey key, void* value) {
@@ -146,8 +144,7 @@ inline void* ThreadSpecificGet(ThreadSpecificKey key) {
template <typename T>
inline ThreadSpecific<T>::ThreadSpecific() {
int error = pthread_key_create(&key_, Destroy);
- if (error)
- IMMEDIATE_CRASH();
+ CHECK(!error);
}
template <typename T>
@@ -191,12 +188,10 @@ WTF_EXPORT void* ThreadSpecificGet(ThreadSpecificKey);
template <typename T>
inline ThreadSpecific<T>::ThreadSpecific() : index_(-1) {
DWORD tls_key = TlsAlloc();
- if (tls_key == TLS_OUT_OF_INDEXES)
- IMMEDIATE_CRASH();
+ CHECK_NE(tls_key, TLS_OUT_OF_INDEXES);
index_ = InterlockedIncrement(&TlsKeyCount()) - 1;
- if (index_ >= kMaxTlsKeySize)
- IMMEDIATE_CRASH();
+ CHECK_LE(index_, kMaxTlsKeySize);
TlsKeys()[index_] = tls_key;
}

Powered by Google App Engine
This is Rietveld 408576698