This will have the same results as the non-exotic version, but sometimes with quantization error ...
3 years, 6 months ago
(2017-05-31 21:40:26 UTC)
#2
This will have the same results as the non-exotic version, but sometimes with
quantization error for the wide intermediate color space.
qyearsley
I don't see any problem with this and I think it's good to submit as ...
3 years, 6 months ago
(2017-05-31 21:45:45 UTC)
#3
I don't see any problem with this and I think it's good to submit as long as
enne@ has reviewed it.
A couple background questions though: is there any other particular reasons why
"color-spin-gamma24" is used? Exotic here mainly just means "different from
sRGB" right?
ccameron
On 2017/05/31 21:45:45, qyearsley wrote: > I don't see any problem with this and I ...
3 years, 6 months ago
(2017-05-31 23:15:28 UTC)
#4
On 2017/05/31 21:45:45, qyearsley wrote:
> I don't see any problem with this and I think it's good to submit as long as
> enne@ has reviewed it.
>
> A couple background questions though: is there any other particular reasons
why
> "color-spin-gamma24" is used? Exotic here mainly just means "different from
> sRGB" right?
Exotic means two things here (put them in the README.txt)
- gamma is not considered by be the same as sRGB by skia, which totally changes
that paths that are exercised
- the primaries are completely different from the sRGB primaries, so if we don't
convert primaries, things will look totally wrong
enne (OOO)
lgtm
3 years, 6 months ago
(2017-06-01 15:08:36 UTC)
#5
lgtm
qyearsley
lgtm
3 years, 6 months ago
(2017-06-01 21:32:47 UTC)
#6
lgtm
ccameron
The CQ bit was checked by ccameron@chromium.org
3 years, 6 months ago
(2017-06-08 06:47:23 UTC)
#7
CQ is committing da patch. Bot data: {"patchset_id": 80001, "attempt_start_ts": 1496904443347270, "parent_rev": "020c1992c67d99bd0a6d994ce6d14d450a639ed7", "commit_rev": "a47b053713e2eb2c49cb9f9db0d95346d941a2b6"}
3 years, 6 months ago
(2017-06-08 09:02:00 UTC)
#10
CQ is committing da patch.
Bot data: {"patchset_id": 80001, "attempt_start_ts": 1496904443347270,
"parent_rev": "020c1992c67d99bd0a6d994ce6d14d450a639ed7", "commit_rev":
"a47b053713e2eb2c49cb9f9db0d95346d941a2b6"}
commit-bot: I haz the power
CQ is committing da patch. Bot data: {"patchset_id": 80001, "attempt_start_ts": 1496904443347270, "parent_rev": "d4c4887d73722e888560ecb61c56f3950852fd1a", "commit_rev": "d9072312c7152bcbfc21df56e7646dd2870b1dc0"}
3 years, 6 months ago
(2017-06-08 09:02:16 UTC)
#11
CQ is committing da patch.
Bot data: {"patchset_id": 80001, "attempt_start_ts": 1496904443347270,
"parent_rev": "d4c4887d73722e888560ecb61c56f3950852fd1a", "commit_rev":
"d9072312c7152bcbfc21df56e7646dd2870b1dc0"}
commit-bot: I haz the power
Description was changed from ========== color: Add virtual test suites for images/ with exotic color ...
3 years, 6 months ago
(2017-06-08 09:02:29 UTC)
#12
Message was sent while issue was closed.
Description was changed from
==========
color: Add virtual test suites for images/ with exotic color profiles
Add two virtual test suites -- SW and GPU raster for images/ with an
exotic color space.
BUG=713891
==========
to
==========
color: Add virtual test suites for images/ with exotic color profiles
Add two virtual test suites -- SW and GPU raster for images/ with an
exotic color space.
BUG=713891
Review-Url: https://codereview.chromium.org/2919643002
Cr-Commit-Position: refs/heads/master@{#477926}
Committed:
https://chromium.googlesource.com/chromium/src/+/d9072312c7152bcbfc21df56e764...
==========
commit-bot: I haz the power
Committed patchset #5 (id:80001) as https://chromium.googlesource.com/chromium/src/+/d9072312c7152bcbfc21df56e7646dd2870b1dc0
3 years, 6 months ago
(2017-06-08 09:02:31 UTC)
#13
Issue 2919643002: color: Add virtual test suites for images/ with exotic color profiles
(Closed)
Created 3 years, 6 months ago by ccameron
Modified 3 years, 6 months ago
Reviewers: qyearsley, enne (OOO)
Base URL:
Comments: 0