Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(174)

Issue 2919593005: [Autofill] Use Drawable instead of iconId in Autofill prefs (Closed)

Created:
3 years, 6 months ago by Mathieu
Modified:
3 years, 6 months ago
Reviewers:
Ted C
CC:
chromium-reviews, agrieve+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

[Autofill] Use Drawable instead of iconId in Autofill prefs BUG=728116 TEST=crash no longer repros Review-Url: https://codereview.chromium.org/2919593005 Cr-Commit-Position: refs/heads/master@{#476306} Committed: https://chromium.googlesource.com/chromium/src/+/3519b0735c2d97c0873f8d227d5e80b568e0933d

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -2 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/preferences/autofill/AutofillCreditCardsFragment.java View 3 chunks +4 lines, -2 lines 0 comments Download

Messages

Total messages: 15 (9 generated)
Mathieu
Ganggui, PTAL
3 years, 6 months ago (2017-06-01 00:40:28 UTC) #2
Mathieu
Ted, PTAL, this fixes a crash because we were not using the support library for ...
3 years, 6 months ago (2017-06-01 00:51:12 UTC) #4
Ted C
lgtm
3 years, 6 months ago (2017-06-01 14:03:48 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2919593005/1
3 years, 6 months ago (2017-06-01 15:04:07 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2919593005/1
3 years, 6 months ago (2017-06-01 15:22:03 UTC) #10
commit-bot: I haz the power
3 years, 6 months ago (2017-06-01 15:53:27 UTC) #15
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/3519b0735c2d97c0873f8d227d5e...

Powered by Google App Engine
This is Rietveld 408576698