Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(250)

Issue 2919593004: Remove dependency of ColorChooserPopupUIController on ChromeClientImpl (Closed)

Created:
3 years, 6 months ago by sashab
Modified:
3 years, 6 months ago
Reviewers:
slangley, haraken, dcheng, kinuko
CC:
blink-reviews, chromium-reviews, kinuko+watch, platform-architecture-syd+reviews-web_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove dependency of ColorChooserPopupUIController on ChromeClientImpl BUG=712963 Review-Url: https://codereview.chromium.org/2919593004 Cr-Commit-Position: refs/heads/master@{#476238} Committed: https://chromium.googlesource.com/chromium/src/+/2c935aff0c6cfb6c1863d3f875f46ba6100031ae

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -6 lines) Patch
M third_party/WebKit/Source/web/ColorChooserPopupUIController.h View 3 chunks +4 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/web/ColorChooserPopupUIController.cpp View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 15 (8 generated)
sashab
slangley ptal first of haraken/dcheng/kinuko to see this ptal :)
3 years, 6 months ago (2017-05-31 23:41:48 UTC) #2
slangley
lgtm
3 years, 6 months ago (2017-05-31 23:43:11 UTC) #3
dcheng
lgtm
3 years, 6 months ago (2017-06-01 00:19:55 UTC) #6
haraken
LGTM
3 years, 6 months ago (2017-06-01 00:30:33 UTC) #7
kinuko
lgtm
3 years, 6 months ago (2017-06-01 02:10:18 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2919593004/1
3 years, 6 months ago (2017-06-01 09:31:24 UTC) #12
commit-bot: I haz the power
3 years, 6 months ago (2017-06-01 09:34:31 UTC) #15
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/2c935aff0c6cfb6c1863d3f875f4...

Powered by Google App Engine
This is Rietveld 408576698