Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(188)

Issue 2919553004: Remove base::android::OnJNIOnLoadRegisterJNI() (Closed)

Created:
3 years, 6 months ago by pauljensen
Modified:
3 years, 6 months ago
CC:
Aaron Boodman, abarth-chromium, agrieve+watch_chromium.org, cbentzel+watch_chromium.org, chromium-reviews, chromoting-reviews_chromium.org, danakj+watch_chromium.org, darin (slow to review), darin-cc_chromium.org, jam, jbudorick+watch_chromium.org, mikecase+watch_chromium.org, net-reviews_chromium.org, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, vmpstr+watch_chromium.org, yzshen+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove base::android::OnJNIOnLoadRegisterJNI() It was calling one JNI registration method which is moved to base::android::RegisterJNI() CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_cronet_tester Review-Url: https://codereview.chromium.org/2919553004 Cr-Commit-Position: refs/heads/master@{#480050} Committed: https://chromium.googlesource.com/chromium/src/+/aec635bc9800adca0411d3bc92c9b779f92221aa

Patch Set 1 #

Patch Set 2 : remove unused Callback #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -23 lines) Patch
M base/android/base_jni_onload.h View 1 1 chunk +0 lines, -4 lines 0 comments Download
M base/android/base_jni_onload.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M base/android/base_jni_registrar.cc View 2 chunks +2 lines, -0 lines 0 comments Download
M components/cronet/android/cronet_library_loader.cc View 1 chunk +1 line, -2 lines 0 comments Download
M components/cronet/android/test/cronet_test_jni.cc View 1 chunk +1 line, -2 lines 0 comments Download
M content/app/android/content_jni_onload.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M mojo/android/javatests/init_library.cc View 1 chunk +1 line, -2 lines 0 comments Download
M net/test/android/net_test_jni_onload.cc View 1 chunk +1 line, -2 lines 0 comments Download
M remoting/client/jni/remoting_jni_onload.cc View 1 chunk +1 line, -2 lines 0 comments Download
M testing/android/native_test/native_test_jni_onload.cc View 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 31 (16 generated)
pauljensen
Torne, PTAL, thank you!
3 years, 6 months ago (2017-06-01 16:52:01 UTC) #8
Torne
Hrm. I'm not sure why we had this separately in the first place. +michaelbai might ...
3 years, 6 months ago (2017-06-01 16:56:51 UTC) #10
pauljensen
I'm pretty sure this CL is a no-op functionally. Since I've removed the function you ...
3 years, 6 months ago (2017-06-01 17:51:52 UTC) #13
michaelbai
On 2017/06/01 16:56:51, Torne wrote: > Hrm. I'm not sure why we had this separately ...
3 years, 6 months ago (2017-06-01 18:17:21 UTC) #14
Torne
LGTM
3 years, 6 months ago (2017-06-01 18:48:44 UTC) #15
pauljensen
On 2017/06/01 18:17:21, michaelbai wrote: > On 2017/06/01 16:56:51, Torne wrote: > > Hrm. I'm ...
3 years, 6 months ago (2017-06-01 23:10:02 UTC) #16
pauljensen
sergeyu, please review remoting/ michaelbai, please review content/ rockot, please review mojo/
3 years, 6 months ago (2017-06-01 23:17:04 UTC) #18
Ken Rockot(use gerrit already)
lgtm
3 years, 6 months ago (2017-06-01 23:18:38 UTC) #19
michaelbai
content/app/android LGTM
3 years, 6 months ago (2017-06-02 00:07:04 UTC) #20
pauljensen
Sergey, friendly ping for a tiny review.
3 years, 6 months ago (2017-06-03 03:10:49 UTC) #21
Sergey Ulanov
lgtm
3 years, 6 months ago (2017-06-05 18:13:48 UTC) #22
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2919553004/20001
3 years, 6 months ago (2017-06-05 18:16:50 UTC) #24
commit-bot: I haz the power
Try jobs failed on following builders: linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_android_rel_ng/builds/310663)
3 years, 6 months ago (2017-06-05 21:44:17 UTC) #26
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2919553004/20001
3 years, 6 months ago (2017-06-16 13:22:55 UTC) #28
commit-bot: I haz the power
3 years, 6 months ago (2017-06-16 15:21:58 UTC) #31
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/aec635bc9800adca0411d3bc92c9...

Powered by Google App Engine
This is Rietveld 408576698