Remove base::android::OnJNIOnLoadRegisterJNI()

Remove base::android::OnJNIOnLoadRegisterJNI()

It was calling one JNI registration method which is moved to
base::android::RegisterJNI()

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_cronet_tester

Review-Url: https://codereview.chromium.org/2919553004
Cr-Commit-Position: refs/heads/master@{#480050}
Committed: https://chromium.googlesource.com/chromium/src/+/aec635bc9800adca0411d3bc92c9b779f92221aa

[pauljensen, 2017-06-01 16:16:39]

Description was changed from

==========
Remove base::android::OnJNIOnLoadRegisterJNI()

It was calling one JNI registration method which is moved to
base::android::RegisterJNI()
==========

to

==========
Remove base::android::OnJNIOnLoadRegisterJNI()

It was calling one JNI registration method which is moved to
base::android::RegisterJNI()
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_cronet_tester
==========

[pauljensen, 2017-06-01 16:16:53]

The CQ bit was checked by pauljensen@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-01 16:17:21]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[pauljensen, 2017-06-01 16:35:28]

Description was changed from

==========
Remove base::android::OnJNIOnLoadRegisterJNI()

It was calling one JNI registration method which is moved to
base::android::RegisterJNI()
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_cronet_tester
==========

to

==========
Remove base::android::OnJNIOnLoadRegisterJNI()

It was calling one JNI registration method which is moved to
base::android::RegisterJNI()

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_cronet_tester
==========

[pauljensen, 2017-06-01 16:44:17]

The CQ bit was checked by pauljensen@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-01 16:44:23]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[pauljensen, 2017-06-01 16:52:00]

pauljensen@chromium.org changed reviewers:
+ torne@chromium.org

[pauljensen, 2017-06-01 16:52:01]

Torne, PTAL, thank you!

[Torne, 2017-06-01 16:56:50]

torne@chromium.org changed reviewers:
+ michaelbai@chromium.org

[Torne, 2017-06-01 16:56:51]

Hrm. I'm not sure why we had this separately in the first place. +michaelbai
might remember?

Have you tested this locally for a build of Chrome that actually relies on
manual registration? I don't know if that's really covered by the trybots.

[commit-bot: I haz the power, 2017-06-01 17:43:10]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-01 17:43:11]

Dry run: This issue passed the CQ dry run.

[pauljensen, 2017-06-01 17:51:52]

I'm pretty sure this CL is a no-op functionally.  Since I've removed the
function you can see all call-sites in the CL.  Ignoring the tests you're left
with:
  Cronet: Immediately calls base::android::RegisterJNI() (via RegisterJNI)
  content/app: Immediately calls base::android::RegisterJNI() (via
content::EnsureJniRegistered)
  remoting: Immediately calls base::android::RegisterJNI() (via RegisterJNI)
I moved the once JNI registration from base::android::OnJNIOnLoadRegisterJNI()
to base::android::RegisterJNI().

On 2017/06/01 16:56:51, Torne wrote:
> Hrm. I'm not sure why we had this separately in the first place. +michaelbai
> might remember?

Some CL archeology turns up these relevant historical points: crrev.com/313592
crrev.com/448955

> Have you tested this locally for a build of Chrome that actually relies on
> manual registration? I don't know if that's really covered by the trybots.

The Cronet tests should cover manual registration cases I think.

[michaelbai, 2017-06-01 18:17:21]

On 2017/06/01 16:56:51, Torne wrote:
> Hrm. I'm not sure why we had this separately in the first place. +michaelbai
> might remember?
> 
> Have you tested this locally for a build of Chrome that actually relies on
> manual registration? I don't know if that's really covered by the trybots.

The method has been separated and run before other registration at very
beginning, one reason I could image is that before my refactoring, the the
registration and initialization were mixed together, some latter initialization
might depend on this method to run first?

[Torne, 2017-06-01 18:48:44]

LGTM

[pauljensen, 2017-06-01 23:10:02]

On 2017/06/01 18:17:21, michaelbai wrote:
> On 2017/06/01 16:56:51, Torne wrote:
> > Hrm. I'm not sure why we had this separately in the first place. +michaelbai
> > might remember?
> > 
> > Have you tested this locally for a build of Chrome that actually relies on
> > manual registration? I don't know if that's really covered by the trybots.
> 
> The method has been separated and run before other registration at very
> beginning, one reason I could image is that before my refactoring, the the
> registration and initialization were mixed together, some latter
initialization
> might depend on this method to run first?

Makes sense.  After all the refactoring the JNI registration is all run together
now.

[pauljensen, 2017-06-01 23:17:03]

pauljensen@chromium.org changed reviewers:
+ rockot@chromium.org, sergeyu@chromium.org

[pauljensen, 2017-06-01 23:17:04]

sergeyu, please review remoting/
michaelbai, please review content/
rockot, please review mojo/

[Ken Rockot(use gerrit already), 2017-06-01 23:18:38]

lgtm

[michaelbai, 2017-06-02 00:07:04]

content/app/android LGTM

[pauljensen, 2017-06-03 03:10:49]

Sergey, friendly ping for a tiny review.

[Sergey Ulanov, 2017-06-05 18:13:48]

lgtm

[pauljensen, 2017-06-05 18:16:02]

The CQ bit was checked by pauljensen@chromium.org

[commit-bot: I haz the power, 2017-06-05 18:16:50]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-05 21:44:16]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-05 21:44:17]

Try jobs failed on following builders:
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[pauljensen, 2017-06-16 13:22:39]

The CQ bit was checked by pauljensen@chromium.org

[commit-bot: I haz the power, 2017-06-16 13:22:55]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-16 15:21:43]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1497619359955340,
"parent_rev": "2b7bf9311f65ccdc06f992be97dddbacbc71475c", "commit_rev":
"aec635bc9800adca0411d3bc92c9b779f92221aa"}

[commit-bot: I haz the power, 2017-06-16 15:21:54]

Description was changed from

==========
Remove base::android::OnJNIOnLoadRegisterJNI()

It was calling one JNI registration method which is moved to
base::android::RegisterJNI()

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_cronet_tester
==========

to

==========
Remove base::android::OnJNIOnLoadRegisterJNI()

It was calling one JNI registration method which is moved to
base::android::RegisterJNI()

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_cronet_tester

Review-Url: https://codereview.chromium.org/2919553004
Cr-Commit-Position: refs/heads/master@{#480050}
Committed:
https://chromium.googlesource.com/chromium/src/+/aec635bc9800adca0411d3bc92c9...
==========

[commit-bot: I haz the power, 2017-06-16 15:21:58]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/aec635bc9800adca0411d3bc92c9...