third_party/WebKit/Source/core/dom/ElementVisibilityObserver.cpp - Issue 2919543002: [ElementVisibilityObserver] Fix regression with default threshold

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/dom/ElementVisibilityObserver.cpp

Issue 2919543002: [ElementVisibilityObserver] Fix regression with default threshold (Closed)

Patch Set: Add link Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/dom/ElementVisibilityObserver.cpp

diff --git a/third_party/WebKit/Source/core/dom/ElementVisibilityObserver.cpp b/third_party/WebKit/Source/core/dom/ElementVisibilityObserver.cpp

index 1bb3b3a29b848bc938c1e43721fcffc4ca49b46f..7fe6e4ab3aa34ff0be5de6df05c241e8776e84ef 100644

--- a/third_party/WebKit/Source/core/dom/ElementVisibilityObserver.cpp

+++ b/third_party/WebKit/Source/core/dom/ElementVisibilityObserver.cpp

@@ -52,7 +52,7 @@ DEFINE_TRACE(ElementVisibilityObserver) {

void ElementVisibilityObserver::OnVisibilityChanged(

const HeapVector<Member<IntersectionObserverEntry>>& entries) {

- bool is_visible = entries.back()->intersectionRatio() >

+ bool is_visible = entries.back()->intersectionRatio() >=

intersection_observer_->thresholds()[0];

(*callback_.get())(is_visible);

}

« no previous file with comments | « third_party/WebKit/Source/core/dom/ElementVisibilityObserver.h ('k') | no next file » | no next file with comments »