third_party/WebKit/Source/core/dom/ElementVisibilityObserver.cpp - Issue 2919543002: [ElementVisibilityObserver] Fix regression with default threshold

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/Source/core/dom/ElementVisibilityObserver.cpp

Issue 2919543002: [ElementVisibilityObserver] Fix regression with default threshold (Closed)

Patch Set: Add link Created 3 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « third_party/WebKit/Source/core/dom/ElementVisibilityObserver.h ('k') | no next file » | no next file with comments »

OLD	NEW
1 // Copyright 2016 The Chromium Authors. All rights reserved.	1 // Copyright 2016 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #include "core/dom/ElementVisibilityObserver.h"	5 #include "core/dom/ElementVisibilityObserver.h"

6	6

7 #include "core/dom/Element.h"	7 #include "core/dom/Element.h"

8 #include "core/dom/IntersectionObserverEntry.h"	8 #include "core/dom/IntersectionObserverEntry.h"

9 #include "core/frame/LocalFrame.h"	9 #include "core/frame/LocalFrame.h"

10 #include "platform/wtf/Functional.h"	10 #include "platform/wtf/Functional.h"

(...skipping 34 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
45 intersection_observer_->Deliver();	45 intersection_observer_->Deliver();

46 }	46 }

47	47

48 DEFINE_TRACE(ElementVisibilityObserver) {	48 DEFINE_TRACE(ElementVisibilityObserver) {

49 visitor->Trace(element_);	49 visitor->Trace(element_);

50 visitor->Trace(intersection_observer_);	50 visitor->Trace(intersection_observer_);

51 }	51 }

52	52

53 void ElementVisibilityObserver::OnVisibilityChanged(	53 void ElementVisibilityObserver::OnVisibilityChanged(

54 const HeapVector<Member<IntersectionObserverEntry>>& entries) {	54 const HeapVector<Member<IntersectionObserverEntry>>& entries) {

55 bool is_visible = entries.back()->intersectionRatio() >	55 bool is_visible = entries.back()->intersectionRatio() >=

56 intersection_observer_->thresholds()[0];	56 intersection_observer_->thresholds()[0];

57 (*callback_.get())(is_visible);	57 (*callback_.get())(is_visible);

58 }	58 }

59	59

60 } // namespace blink	60 } // namespace blink

OLD	NEW