Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(44)

Issue 2919523005: Add avatar badges and update caps lock icon for new login screen (Closed)

Created:
3 years, 6 months ago by Wenzhao (Colin) Zang
Modified:
3 years, 6 months ago
CC:
chromium-reviews, alemate+watch_chromium.org, achuith+watch_chromium.org, rkc
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Add avatar badges and update caps lock icon for new login screen 1) Added supervised-user and signed-in user badge. We do not have designs for other badges yet and I need to investigate on all other badge types to see which one should be switched to the new style. Before that we hide all other badges to avoid style conflict. 2) Updated caps lock icon to match the new spec. BUG=718159 Review-Url: https://codereview.chromium.org/2919523005 Cr-Commit-Position: refs/heads/master@{#476517} Committed: https://chromium.googlesource.com/chromium/src/+/5cbd575ebf4790240c8c30159ce17eebfd1a1ea3

Patch Set 1 #

Total comments: 4

Patch Set 2 : Adjust line length #

Patch Set 3 : rebase with master #

Patch Set 4 : rebase with master #

Unified diffs Side-by-side diffs Delta from patch set Stats (+67 lines, -23 lines) Patch
M ui/login/account_picker/md_user_pod_row.css View 1 2 3 5 chunks +45 lines, -8 lines 0 comments Download
M ui/login/account_picker/md_user_pod_row.js View 1 2 2 chunks +4 lines, -8 lines 0 comments Download
M ui/login/account_picker/md_user_pod_template.html View 1 2 4 chunks +18 lines, -7 lines 0 comments Download

Messages

Total messages: 17 (10 generated)
Wenzhao (Colin) Zang
alemate@ (owner review), jdufault@, please look at this simple CL. Thanks a lot.
3 years, 6 months ago (2017-06-01 00:14:25 UTC) #6
Wenzhao (Colin) Zang
xiyuan@, would you please look at this CL as owner? We hope to land it ...
3 years, 6 months ago (2017-06-01 22:09:34 UTC) #8
jdufault
lgtm https://codereview.chromium.org/2919523005/diff/1/ui/login/account_picker/md_user_pod_template.html File ui/login/account_picker/md_user_pod_template.html (right): https://codereview.chromium.org/2919523005/diff/1/ui/login/account_picker/md_user_pod_template.html#newcode43 ui/login/account_picker/md_user_pod_template.html:43: <iron-icon class="legacy-supervised-badge" icon="user-pod:legacy-supervised-badge"></iron-icon> nit: line length https://codereview.chromium.org/2919523005/diff/1/ui/login/account_picker/md_user_pod_template.html#newcode129 ui/login/account_picker/md_user_pod_template.html:129: ...
3 years, 6 months ago (2017-06-01 22:14:31 UTC) #9
Wenzhao (Colin) Zang
https://codereview.chromium.org/2919523005/diff/1/ui/login/account_picker/md_user_pod_template.html File ui/login/account_picker/md_user_pod_template.html (right): https://codereview.chromium.org/2919523005/diff/1/ui/login/account_picker/md_user_pod_template.html#newcode43 ui/login/account_picker/md_user_pod_template.html:43: <iron-icon class="legacy-supervised-badge" icon="user-pod:legacy-supervised-badge"></iron-icon> On 2017/06/01 22:14:31, jdufault wrote: > ...
3 years, 6 months ago (2017-06-01 22:23:10 UTC) #10
xiyuan
lgtm
3 years, 6 months ago (2017-06-01 22:28:13 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2919523005/60001
3 years, 6 months ago (2017-06-02 01:28:31 UTC) #14
commit-bot: I haz the power
3 years, 6 months ago (2017-06-02 01:39:51 UTC) #17
Message was sent while issue was closed.
Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/5cbd575ebf4790240c8c30159ce1...

Powered by Google App Engine
This is Rietveld 408576698