Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(200)

Issue 2919523004: Surface synchronization: Don't gutter translucent windows (Closed)

Created:
3 years, 6 months ago by Fady Samuel
Modified:
3 years, 6 months ago
Reviewers:
Tom Sepez, sky
CC:
chromium-reviews, rjkroege, sadrul, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, tfarina, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, kalyank, darin (slow to review)
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Surface synchronization: Don't gutter translucent windows This CL does two things: 1. It propagates the translucent bit to the window manager so that it can update its top level window. 2. It skips guttering in ClientSurfaceEmbedder if the window is transparent. BUG=672962 TBR=tsepez@chromium.org Review-Url: https://codereview.chromium.org/2919523004 Cr-Commit-Position: refs/heads/master@{#476123} Committed: https://chromium.googlesource.com/chromium/src/+/0924893aff1ceb991c789862db5ecff6802330c1

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -2 lines) Patch
M ash/mus/top_level_window_factory.cc View 1 chunk +10 lines, -0 lines 0 comments Download
M services/ui/public/interfaces/window_manager.mojom View 1 chunk +3 lines, -0 lines 0 comments Download
M ui/aura/mus/client_surface_embedder.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M ui/views/mus/mus_client.cc View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 20 (12 generated)
Fady Samuel
PTAL Scott!
3 years, 6 months ago (2017-05-31 23:20:29 UTC) #2
Fady Samuel
+sadrul@ in cc: FYI
3 years, 6 months ago (2017-05-31 23:20:49 UTC) #4
sky
LGTM
3 years, 6 months ago (2017-05-31 23:37:52 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2919523004/1
3 years, 6 months ago (2017-06-01 00:52:03 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/452759)
3 years, 6 months ago (2017-06-01 01:02:24 UTC) #12
Fady Samuel
+tsepez@ for mojom. I'm TBR'ing because no new IPCs are introduced aside from an extra ...
3 years, 6 months ago (2017-06-01 01:04:44 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2919523004/1
3 years, 6 months ago (2017-06-01 01:05:47 UTC) #17
commit-bot: I haz the power
3 years, 6 months ago (2017-06-01 01:12:57 UTC) #20
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/0924893aff1ceb991c789862db5e...

Powered by Google App Engine
This is Rietveld 408576698