Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(806)

Issue 2919523002: Do not delete sub key if main key was not found in ChromeTestLauncherDelegate::PreSharding() (Closed)

Created:
3 years, 6 months ago by gab
Modified:
3 years, 6 months ago
Reviewers:
Nico
CC:
chromium-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Do not delete sub key if main key was not found in ChromeTestLauncherDelegate::PreSharding() Otherwise DeleteKey hits DCHECK(key_) when distrubution_key.Open() results in ERROR_FILE_NOT_FOUND. BUG=724350 Review-Url: https://codereview.chromium.org/2919523002 Cr-Commit-Position: refs/heads/master@{#475965} Committed: https://chromium.googlesource.com/chromium/src/+/978ad0704f0ab11c422088c6b468aabdf10ff4b5

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -7 lines) Patch
M chrome/test/base/chrome_test_launcher.cc View 1 chunk +5 lines, -7 lines 0 comments Download

Messages

Total messages: 13 (8 generated)
gab
Nico PTaL (and CQ), thanks!
3 years, 6 months ago (2017-05-31 16:13:19 UTC) #4
Nico
lgtm What triggered this problem? Is this a recent regression?
3 years, 6 months ago (2017-05-31 17:32:51 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2919523002/1
3 years, 6 months ago (2017-05-31 17:33:32 UTC) #9
gab
On 2017/05/31 17:32:51, Nico (vacation Jun 3-11) wrote: > lgtm > > What triggered this ...
3 years, 6 months ago (2017-05-31 17:34:43 UTC) #10
commit-bot: I haz the power
3 years, 6 months ago (2017-05-31 18:36:58 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/978ad0704f0ab11c422088c6b468...

Powered by Google App Engine
This is Rietveld 408576698