Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(13)

Issue 2919503004: [Media Controls] Fix and re-enable failing metrics tests on Android (Closed)

Created:
3 years, 6 months ago by johnme
Modified:
3 years, 6 months ago
CC:
chromium-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

[Media Controls] Fix and re-enable failing metrics tests on Android BUG=709483 Review-Url: https://codereview.chromium.org/2919503004 Cr-Commit-Position: refs/heads/master@{#476266} Committed: https://chromium.googlesource.com/chromium/src/+/a262e4f88d16b143b9f754865db584e3bc9ec01c

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+37 lines, -57 lines) Patch
M third_party/WebKit/Source/modules/media_controls/MediaControlsImplTest.cpp View 6 chunks +37 lines, -57 lines 0 comments Download

Messages

Total messages: 12 (8 generated)
johnme
3 years, 6 months ago (2017-06-01 11:22:19 UTC) #2
mlamouri (slow - plz ping)
lgtm
3 years, 6 months ago (2017-06-01 11:59:53 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2919503004/1
3 years, 6 months ago (2017-06-01 13:24:15 UTC) #9
commit-bot: I haz the power
3 years, 6 months ago (2017-06-01 13:28:32 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/a262e4f88d16b143b9f754865db5...

Powered by Google App Engine
This is Rietveld 408576698