Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2919503003:
Extract InlineBox handling from MostBackwardCaretPosition() (Closed)
|
Created:
3 years, 6 months ago by yosin_UTC9 Modified:
3 years, 6 months ago CC:
blink-reviews, chromium-reviews Target Ref:
refs/heads/master Project:
chromium Visibility:
Public. |
DescriptionExtract InlineBox handling from MostBackwardCaretPosition()
This patch extracts |InlineBox| handling code fragment into
|IsOffsetRenderedForBackward()| for ease of adopting
|MostBackwardCaretPosition()| to Layout NG.
Note: The patch[1] does same thing for |MostForkwardCaretPosition()|
[1] http://crrev.com/2918783002: Extract InlineBox handling from
MostForkwardCaretPosition()
BUG=707656
TEST=n/a; no behavior changes
Review-Url: https://codereview.chromium.org/2919503003
Cr-Commit-Position: refs/heads/master@{#477214}
Committed: https://chromium.googlesource.com/chromium/src/+/ff1e24a705ef71b37dec0cb8a9e83f2f84327a7d
Patch Set 1 : 2017-06-01T18:41:35 #Patch Set 2 : 2017-06-05T18:14:47 #
Total comments: 2
Patch Set 3 : 2017-06-06T13:42:15 #Messages
Total messages: 30 (23 generated)
The CQ bit was checked by yosin@chromium.org to run a CQ dry run
Patchset #1 (id:1) has been deleted
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Description was changed from ========== 2017-06-01T16:23:31 BUG=707656 2017-06-01T16:22:37 ========== to ========== Extract InlineBox handling from MostBackwardCaretPosition() This patch extracts |InlineBox| handling code fragment into |IsOffsetRenderedForBackward()| for ease of adopting |MostBackwardCaretPosition()| to Layout NG. Note: The patch[1] does same thing for |MostForkwardCaretPosition()| [1] http://crrev.com/2918783002: Extract InlineBox handling from MostForkwardCaretPosition() BUG=707656 TEST=n/a; no behavior changes ==========
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
yosin@chromium.org changed reviewers: + xiaochengh@chromium.org, yoichio@chromium.org
PTAL
The CQ bit was checked by yosin@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Patchset #1 (id:20001) has been deleted
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
lgtm
The CQ bit was checked by yosin@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
PTAL Change as http://crrev.com/2918783002 for MostForwadCaretPosition()
The CQ bit was checked by yosin@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Patchset #2 (id:60001) has been deleted
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
lgtm https://codereview.chromium.org/2919503003/diff/80001/third_party/WebKit/Sour... File third_party/WebKit/Source/core/editing/VisibleUnits.cpp (right): https://codereview.chromium.org/2919503003/diff/80001/third_party/WebKit/Sour... third_party/WebKit/Source/core/editing/VisibleUnits.cpp:2662: static bool CanBackwardCaretPosition(const LayoutText* text_layout_object, nit: |CanBeBackwardCaretPosition| seems a better name.
Thanks for reviewing! Committing... https://codereview.chromium.org/2919503003/diff/80001/third_party/WebKit/Sour... File third_party/WebKit/Source/core/editing/VisibleUnits.cpp (right): https://codereview.chromium.org/2919503003/diff/80001/third_party/WebKit/Sour... third_party/WebKit/Source/core/editing/VisibleUnits.cpp:2662: static bool CanBackwardCaretPosition(const LayoutText* text_layout_object, On 2017/06/05 at 19:36:37, Xiaocheng wrote: > nit: |CanBeBackwardCaretPosition| seems a better name. Done. Thanks for providing good name.
The CQ bit was checked by yosin@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from yoichio@chromium.org, xiaochengh@chromium.org Link to the patchset: https://codereview.chromium.org/2919503003/#ps100001 (title: "2017-06-06T13:42:15")
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 100001, "attempt_start_ts": 1496724534468030,
"parent_rev": "28efe6a5918b0a0cb890b5f93c09f5d1d1216cdf", "commit_rev":
"ff1e24a705ef71b37dec0cb8a9e83f2f84327a7d"}
Message was sent while issue was closed.
Description was changed from ========== Extract InlineBox handling from MostBackwardCaretPosition() This patch extracts |InlineBox| handling code fragment into |IsOffsetRenderedForBackward()| for ease of adopting |MostBackwardCaretPosition()| to Layout NG. Note: The patch[1] does same thing for |MostForkwardCaretPosition()| [1] http://crrev.com/2918783002: Extract InlineBox handling from MostForkwardCaretPosition() BUG=707656 TEST=n/a; no behavior changes ========== to ========== Extract InlineBox handling from MostBackwardCaretPosition() This patch extracts |InlineBox| handling code fragment into |IsOffsetRenderedForBackward()| for ease of adopting |MostBackwardCaretPosition()| to Layout NG. Note: The patch[1] does same thing for |MostForkwardCaretPosition()| [1] http://crrev.com/2918783002: Extract InlineBox handling from MostForkwardCaretPosition() BUG=707656 TEST=n/a; no behavior changes Review-Url: https://codereview.chromium.org/2919503003 Cr-Commit-Position: refs/heads/master@{#477214} Committed: https://chromium.googlesource.com/chromium/src/+/ff1e24a705ef71b37dec0cb8a9e8... ==========
Message was sent while issue was closed.
Committed patchset #3 (id:100001) as https://chromium.googlesource.com/chromium/src/+/ff1e24a705ef71b37dec0cb8a9e8... |
