Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(94)

Issue 2919473004: Remove _URLOnStartLoading from crw_web_controller (Closed)

Created:
3 years, 6 months ago by mrefaat
Modified:
3 years, 6 months ago
CC:
chromium-reviews, Eugene But (OOO till 7-30), ios-reviews+web_chromium.org, ios-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove _URLOnStartLoading from crw_web_controller Remove _URLOnStartLoading from crw_web_controller as its not read anywhere. BUG= Review-Url: https://codereview.chromium.org/2919473004 Cr-Commit-Position: refs/heads/master@{#476451} Committed: https://chromium.googlesource.com/chromium/src/+/ae0d11211bae4d973474c10a26c40dc54cd97073

Patch Set 1 #

Patch Set 2 : move description to other cl #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -9 lines) Patch
M ios/web/web_state/ui/crw_web_controller.mm View 6 chunks +0 lines, -9 lines 0 comments Download

Messages

Total messages: 17 (10 generated)
mrefaat
3 years, 6 months ago (2017-06-01 19:55:23 UTC) #4
Eugene But (OOO till 7-30)
You also want to update the test which is failing. Do you want to split ...
3 years, 6 months ago (2017-06-01 20:44:17 UTC) #8
mrefaat
On 2017/06/01 20:44:17, Eugene But wrote: > You also want to update the test which ...
3 years, 6 months ago (2017-06-01 21:05:02 UTC) #9
kkhorimoto
lgtm
3 years, 6 months ago (2017-06-01 21:09:26 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2919473004/20001
3 years, 6 months ago (2017-06-01 21:12:24 UTC) #13
Eugene But (OOO till 7-30)
lgtm, thanks for cleanup!
3 years, 6 months ago (2017-06-01 21:12:57 UTC) #14
commit-bot: I haz the power
3 years, 6 months ago (2017-06-01 22:12:22 UTC) #17
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/ae0d11211bae4d973474c10a26c4...

Powered by Google App Engine
This is Rietveld 408576698