Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(254)

Issue 2919453002: Expand TextIterator::Initialize() into constructor (Closed)

Created:
3 years, 6 months ago by yosin_UTC9
Modified:
3 years, 6 months ago
Reviewers:
yoichio, Xiaocheng
CC:
blink-reviews, chromium-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Expand TextIterator::Initialize() into constructor This patch expands |TextIterator::Initialize()| into constructor where the only call sites to simplify code for improving code health. This patch is a follow-up of patch[1], which makes call sites of |Initialize()| to just one. [1] http://crrev.com/2912053002: Call TextIterator constructor with proper range BUG=n/a TEST=n/a; no behavior changes Review-Url: https://codereview.chromium.org/2919453002 Cr-Commit-Position: refs/heads/master@{#475850} Committed: https://chromium.googlesource.com/chromium/src/+/e15b8a7a2ed4a844796968f23113955aa4403a7a

Patch Set 1 : 2017-05-31T16:15:33 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -23 lines) Patch
M third_party/WebKit/Source/core/editing/iterators/TextIterator.h View 1 chunk +0 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/core/editing/iterators/TextIterator.cpp View 2 chunks +12 lines, -18 lines 0 comments Download

Messages

Total messages: 12 (8 generated)
yosin_UTC9
PTAL
3 years, 6 months ago (2017-05-31 07:48:34 UTC) #5
yoichio
lgtm
3 years, 6 months ago (2017-05-31 07:51:38 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2919453002/1
3 years, 6 months ago (2017-05-31 08:02:13 UTC) #9
commit-bot: I haz the power
3 years, 6 months ago (2017-05-31 08:56:17 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/e15b8a7a2ed4a844796968f23113...

Powered by Google App Engine
This is Rietveld 408576698