cc: De-special-case SurfaceLayer code

cc: De-special-case SurfaceLayer code

Currently, there's a bunch of special casing for surface synchronization
in cc::SurfaceLayer. This makes the code hard to read and reason about.
This CL fixes the issue by unifying the two code paths.

A Surface ID referenced as a fallback is always placed in |referenced_surfaces|,
and a surface ID referenced as a primary surface is added to
|activation_dependencies| if the fallback is valid and does not match the
primary.

This CL allows a single code path by setting both primary and fallback
SurfaceInfos in all callsites.

BUG=672962
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel

Review-Url: https://codereview.chromium.org/2919373002
Cr-Commit-Position: refs/heads/master@{#477166}
Committed: https://chromium.googlesource.com/chromium/src/+/cc854aa517e80dbb782f0e2a01563103533cb6be

[Fady Samuel, 2017-06-05 15:18:05]

Description was changed from

==========
cc: De-special-case SurfaceLayer code

Currently, there's a bunch of special casing for surface synchronization
in cc::SurfaceLayer. This makes the code hard to read and reason about.
This CL fixes the issue by unifying the two code paths.

A Surface ID referenced as a fallback is always placed in |referenced_surfaces|,
and a surface ID referenced as a primary surface is added to
|activation_dependencies| if the fallback is valid and does not match the
primary.

This CL allows a single code path by setting both primary and fallback
SurfaceInfos in all callsites.

BUG=672962
==========

to

==========
cc: De-special-case SurfaceLayer code

Currently, there's a bunch of special casing for surface synchronization
in cc::SurfaceLayer. This makes the code hard to read and reason about.
This CL fixes the issue by unifying the two code paths.

A Surface ID referenced as a fallback is always placed in |referenced_surfaces|,
and a surface ID referenced as a primary surface is added to
|activation_dependencies| if the fallback is valid and does not match the
primary.

This CL allows a single code path by setting both primary and fallback
SurfaceInfos in all callsites.

BUG=672962
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
==========

[Fady Samuel, 2017-06-05 15:18:56]

The CQ bit was checked by fsamuel@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-05 15:19:10]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Fady Samuel, 2017-06-05 15:19:27]

fsamuel@chromium.org changed reviewers:
+ piman@chromium.org

[Fady Samuel, 2017-06-05 15:19:27]

+piman@ please review content + cc

[commit-bot: I haz the power, 2017-06-05 15:58:09]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-05 15:58:10]

Dry run: Try jobs failed on following builders:
  android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_...)

[piman, 2017-06-05 16:50:38]

lgtm

[Fady Samuel, 2017-06-05 18:06:56]

The CQ bit was checked by fsamuel@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-05 18:07:09]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Fady Samuel, 2017-06-05 18:07:32]

fsamuel@chromium.org changed reviewers:
+ junov@chromium.org, sadrul@chromium.org

[Fady Samuel, 2017-06-05 18:07:32]

+sadrul@ for ui.
+junov@ for offscreen canvas stuff.

[commit-bot: I haz the power, 2017-06-05 19:04:31]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-05 19:04:32]

Dry run: Try jobs failed on following builders:
  android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_...)
  linux_chromium_tsan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Fady Samuel, 2017-06-05 19:04:59]

The CQ bit was checked by fsamuel@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-05 19:05:31]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[sadrul, 2017-06-05 19:38:51]

lgtm

[Justin Novosad, 2017-06-05 20:07:41]

lgtm

[commit-bot: I haz the power, 2017-06-05 23:20:10]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-05 23:20:11]

Dry run: Try jobs failed on following builders:
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[Fady Samuel, 2017-06-06 00:49:23]

The CQ bit was checked by fsamuel@chromium.org

[Fady Samuel, 2017-06-06 00:49:23]

The patchset sent to the CQ was uploaded after l-g-t-m from piman@chromium.org
Link to the patchset: https://codereview.chromium.org/2919373002/#ps40001
(title: "Fix cc_unittests")

[commit-bot: I haz the power, 2017-06-06 00:49:48]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Fady Samuel, 2017-06-06 02:09:52]

The CQ bit was unchecked by fsamuel@chromium.org

[Fady Samuel, 2017-06-06 02:10:02]

The CQ bit was checked by fsamuel@chromium.org

[commit-bot: I haz the power, 2017-06-06 02:10:28]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-06 03:03:52]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1496715002155690,
"parent_rev": "c10f8ddc5d4a48421c0a0fbe06c88576818c8789", "commit_rev":
"cc854aa517e80dbb782f0e2a01563103533cb6be"}

[commit-bot: I haz the power, 2017-06-06 03:04:01]

Description was changed from

==========
cc: De-special-case SurfaceLayer code

Currently, there's a bunch of special casing for surface synchronization
in cc::SurfaceLayer. This makes the code hard to read and reason about.
This CL fixes the issue by unifying the two code paths.

A Surface ID referenced as a fallback is always placed in |referenced_surfaces|,
and a surface ID referenced as a primary surface is added to
|activation_dependencies| if the fallback is valid and does not match the
primary.

This CL allows a single code path by setting both primary and fallback
SurfaceInfos in all callsites.

BUG=672962
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
==========

to

==========
cc: De-special-case SurfaceLayer code

Currently, there's a bunch of special casing for surface synchronization
in cc::SurfaceLayer. This makes the code hard to read and reason about.
This CL fixes the issue by unifying the two code paths.

A Surface ID referenced as a fallback is always placed in |referenced_surfaces|,
and a surface ID referenced as a primary surface is added to
|activation_dependencies| if the fallback is valid and does not match the
primary.

This CL allows a single code path by setting both primary and fallback
SurfaceInfos in all callsites.

BUG=672962
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel

Review-Url: https://codereview.chromium.org/2919373002
Cr-Commit-Position: refs/heads/master@{#477166}
Committed:
https://chromium.googlesource.com/chromium/src/+/cc854aa517e80dbb782f0e2a0156...
==========

[commit-bot: I haz the power, 2017-06-06 03:04:02]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/cc854aa517e80dbb782f0e2a0156...